Bug 57141

Summary:	repoman lies if the files directory is missing in a package that is in cvs already
Product:	Portage Development	Reporter:	Robin Johnson <robbat2>
Component:	Repoman	Assignee:	Portage team <dev-portage>
Status:	RESOLVED FIXED
Severity:	major	Keywords:	InVCS
Priority:	High
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	repoman-filesdir-check.patch

Description Robin Johnson archtester

2004-07-15 01:32:39 UTC

i found a group of packages, where there was NO files directory, but repoman reported that everything was perfectly fine, and gave no warnings OR errors at all.

these are the packages that were affected:
net-analyzer/authforce app-i18n/manpages-it app-text/build-docbook-catalog dev-java/c3p0 dev-util/jconfig net-firewall/dynfw net-misc/freeswan

noted this to mr_bones_ and ferringb, ferringb cooked up a patch he's going to attach here.

Comment 1 Brian Harring (RETIRED) gentoo-dev

2004-07-15 01:45:51 UTC

Created attachment 35455 [details, diff]
repoman-filesdir-check.patch

This patch is against .51-pre13, although it ought to apply against .50 w/ only
a at worst a hulk failed (easy to merge by hand thouhg).

Basically, if repoman is unable to access CVS/Entries, it just skips that
package, which is *really really* a bad idea.

This corrects it, adding an explicit qacat regarding filesdir missing also.
It's been tested, shouldn't have any issues with it.

Comment 2 Brian Harring (RETIRED) gentoo-dev

2004-07-15 01:47:03 UTC

Also for consideration, please pull in the patch from bug #57068 when commiting this.  
bug #57068 basically fixes the ebuild.allmasked check, simple 1 liner fix.

Comment 3 Brian Harring (RETIRED) gentoo-dev

2004-07-15 01:50:01 UTC

Err... pardon, half awake.
This bug isn't limited to just .51, .50-r9 also suffers from it.
I'd suspect it extends a ways back.

Comment 4 Brian Harring (RETIRED) gentoo-dev

2004-08-05 06:50:04 UTC

I slipped this into .51_pre17, closing.