| Summary: | sys-auth/rtkit: warn if kernel has CONFIG_RT_GROUP_SCHED | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Jonas Jelten <jj> |
| Component: | [OLD] Core system | Assignee: | Marek Szuba <marecki> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | hydrapolic, jj, systemd |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
rtkit-0.11-r1-warn_kernel_rtgroupsched.patch
rtkit-0.11-r1-warn_kernel_rtgroupsched.patch |
||
|
Description
Jonas Jelten
2015-12-23 21:01:38 UTC
The systemd readme recommends this as well: https://github.com/systemd/systemd/blob/ada64a0cff58497147bd856688901f86f86ae1c0/README#L100 Maybe it can directly be added to the systemd ebuild then. This package currently has no maintainer. If you wish and have time, please provide a patch, we can get this into the tree via the proxy maint team. there has been an expression of interest in this by a user however no comment or patch via Comment Sorry, didn't have time for this and i'm no gentoo dev (yet). Maybe I should try becoming one :) However, I think it's better if systemd itself warns about this, not just rtkit. They recommend this kernel config in their readme as I posted before. I am not sure if this belongs to systemd ebuild or this one (or both) :/ Created attachment 426926 [details, diff]
rtkit-0.11-r1-warn_kernel_rtgroupsched.patch
I would say it definitely belongs here - with CONFIG_RT_GROUP_SCHED set rtkit will simply not work unless forced to run as root. As for systemd, the comment in its README is more of a general warning than something specific to it, isn't it?
Anyway, please find attached a patch which makes the sys-auth/rtkit check kernel configuration for CONFIG_RT_GROUP_SCHED and produce a warning if that option is set.
app-emulation/docker-1.10.0 warns if CONFIG_RT_GROUP_SCHED is _not_ set, so that's kind of a conflict here... True, then again having just consulted contrib/check-config.sh in the Docker Github repo, having this kernel feature enabled is optional. It also isn't mentioned at all in the current stable Docker ebuild but that of course can change quite quickly. In the end the matter pretty much grinds down to whether the user prefers to have the Pulseaudio daemon running in real time (it's the only widespread use of rtkit I am aware of) or to have whatever Docker needs this feature for. I would say have both rtkit and docker ebuilds check this, then let the user decide. Created attachment 429292 [details, diff]
rtkit-0.11-r1-warn_kernel_rtgroupsched.patch
Updated the patch to also bump EAPI to 6.
FYI, I have made this a revbump to 0.11-r2. This could have been raised and decided in the discussion within irc. Rather than delay it, I have revbumped it on your behalf, this time. Note that with revbumping, all keywords are set to ~arch. commit 9801ab39cd246510f2bd167021d6f6517dfdce91 Author: Ian Delaney <idella4@gentoo.org> Date: Wed Mar 30 23:46:20 2016 +0800 sys-auth/rtkit: revbump to vn. 0.11-r2 required to effect all changes inherits eclass linux-info, bump to EAPI 6, phase pkg_pretend added to offer to users kernel configuration options. Patch supplied by the proxy maintainer via Gentoo-bug #569546 commit d91cd9c107611aafdd019bb02781f50342b3fa83 Author: Ian Delaney <idella4@gentoo.org> Date: Wed Mar 30 23:31:23 2016 +0800 sys-auth/rtkit: add proxy user Marek Szuba and g-p-m to metadata.xml User given proxy maintainership of the package by request initially via email via the project's alias. Follow up contact made via irc. Support to be provided by the proxy maintainers project, added to metadata. |
