Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 568762

Summary: eutils.eclass: eshopts_push fails with empty option flags
Product: Gentoo Linux Reporter: Ulrich Müller <ulm>
Component: EclassesAssignee: Gentoo's Team for Core System packages <base-system>
Status: RESOLVED FIXED    
Severity: normal Keywords: PATCH
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Properly quote argument in eshopts_push().

Description Ulrich Müller gentoo-dev 2015-12-19 14:02:22 UTC
Created attachment 419772 [details, diff]
Properly quote argument in eshopts_push().

The following sequence of commands (e.g. in src_install):

    set +$-
    eshopts_push
    eshopts_pop

... fails with:

 * ERROR: app-misc/foo-2::local failed (install phase):
 *   eshopts_pop: unbalanced push
 * 
 * Call stack:
 *     ebuild.sh, line  133:  Called src_install
 *   environment, line 1982:  Called eshopts_pop
 *   environment, line  833:  Called die
 * The specific snippet of code:
 *       estack_pop eshopts s || die "${FUNCNAME}: unbalanced push";

Attached patch should fix it.
Comment 1 Ulrich Müller gentoo-dev 2022-01-10 10:24:12 UTC
This has been fixed a long time ago.