Summary: | multibuild.eclass: When broken symbolic link in the source, multibuild_copy_sources fails on G/FBSD. | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Yuta SATOH <nigoro.dev> |
Component: | Eclasses | Assignee: | Michał Górny <mgorny> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | FreeBSD | ||
See Also: | https://github.com/gentoo/gentoo/issues/489 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Yuta SATOH
2015-12-19 00:00:02 UTC
Hmm, the man page doesn't even list '-r'. I guess we should change that to 'cp -R -p' indeed, and possibly also enable 'cp -R -P -p' in multibuild_merge_root() as '-r' probably caused the original symlink issue. I'm going to submit a patch soon, will that be a problem if I asked you to test it? Ok then. Merged just the 'cp -r' -> 'cp -R' change. commit 7adffa3687e1abf7ee24b096b8ab2f39a7ee32b9 Author: Michał Górny <mgorny@gentoo.org> Date: Sat Dec 19 08:57:56 2015 multibuild.eclass: _copy_sources(), use 'cp -R' for BSD compat, #568692 Use 'cp -R' for multibuild_copy_sources() as the '-r' option triggers triggers undesired '-L' behavior wrt symbolic links. Fixes: https://bugs.gentoo.org/show_bug.cgi?id=568692 |