Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 567054

Summary: repoman behavior: handling of missing distfiles
Product: Portage Development Reporter: Robin Johnson <robbat2>
Component: Enhancement/Feature RequestsAssignee: Portage team <dev-portage>
Status: RESOLVED WONTFIX    
Severity: normal CC: infra-bugs, qa
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2015-11-28 23:07:56 UTC
This is similar to bug 116677, but some tweaks are needed for helping infra cases.

The git->rsync scripts re-generate manifests because of ChangeLogs (and $Id$ strings soon).  

However, some developers have been committing new ebuilds without the related distfile updates; in the CVS era, these Manifests would have gone to users without the distfile updates regardless, but now the error is caught at the infra level (and blocks the infra git->rsync).

This causes the re-generation process to try and fetch the distfiles, which fails (as it doesn't have write access to the distdir). It also should NOT happen because the developer has not verified the correct checksum for the distfiles.

I would like a new repoman option that can control the behavior regarding missing distfiles.

--manifest-missing-distfiles=fetch (default if mydo in ["manifest,digest","fetch","unpack"])
--manifest-missing-distfiles=error (warn & fail, default if mydo=manifest-check)
--manifest-missing-distfiles=warn (warn, but do not fail)
--manifest-missing-distfiles=ignore (do not warn or fail)
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-11-29 08:22:18 UTC
warn & ignore would imply re-creating the Manifest with still missing DIST entries?
Comment 2 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2015-11-30 06:50:36 UTC
If updates are needed (eg ChangeLogs), yes, warn & ignore would leave the missing DIST lines missing.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-12 03:18:42 UTC
repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.