Bug 567036 – games-puzzle/numptyphysics-9999 - Failed Patch: numptyphysics-9999-gentoo.patch

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Samuel Bauer 2015-11-28 15:04:22 UTC]

I just come to submit an ebuild for this game which just come to be inserted in the gentoo portage repository.
Meanwhile I was mailing the main game dev about one bug I found in the project.
Ebuild has been integrated with a fix, but it does not apply more as it is already fixed upstream.

While my suggested ebuild used sed in the prepare phase, commited one uses a patch, even new version is way better, I'm surprised to use patches for live ebuild, as any upstream commit may break patching. Using sed in the prepare phase is less sensitive to this problem. As consequence, I often use this way in my personal overlay for live ebuild, and try to stick to the patch way for numbered versions. It's a common problem for most of the live version, when a fix is commited about one known problem, ebuild often tend to fail compiling as gentoo already fixed them (wtf complaints about early fixes), which would not happen using the sed way (even when called with die pipe as in the suggested ebuild).

As consequence, the platform/gl/gl.mk part of the patch isn't applyable

Another little problem with the ebuild is that git-r3 eclass should be the last inherit else it doesn't update/fetch sources.

After fixing the second problem, patch isn't applyable:
 * Package:    games-puzzle/numptyphysics-9999
 * Repository: gentoo
 * Maintainer: games
 * USE:        abi_x86_64 amd64 elibc_glibc kernel_linux user-levels userland_GNU
 * FEATURES:   preserve-libs sandbox splitdebug userpriv usersandbox
>>> Unpacking source...
Initialized empty Git repository in /mnt/gentoo/files/distfiles/git3-src/thp_numptyphysics.git/
 * Fetching https://github.com/thp/numptyphysics ...
git fetch https://github.com/thp/numptyphysics +HEAD:refs/git-r3/HEAD
remote: Counting objects: 2509, done.
remote: Total 2509 (delta 0), reused 0 (delta 0), pack-reused 2509
Receiving objects: 100% (2509/2509), 4.36 MiB | 1.67 MiB/s, done.
Resolving deltas: 100% (1568/1568), done.
From https://github.com/thp/numptyphysics
 * [new ref]                    -> refs/git-r3/HEAD
 * [new tag]         0.3.2      -> 0.3.2
 * [new tag]         0.3.3      -> 0.3.3
git symbolic-ref refs/git-r3/games-puzzle/numptyphysics/0/__main__ refs/heads/master
 * Checking out https://github.com/thp/numptyphysics to /var/tmp/portage/games-puzzle/numptyphysics-9999/work/numptyphysics-9999 ...
git checkout --quiet master
GIT NEW branch -->
   repository:               https://github.com/thp/numptyphysics
   at the commit:            66c07289b5d200e2a2b07c002ee0d340fe14b2a9
>>> Source unpacked in /var/tmp/portage/games-puzzle/numptyphysics-9999/work
>>> Preparing source in /var/tmp/portage/games-puzzle/numptyphysics-9999/work/numptyphysics-9999 ...
 * Applying numptyphysics-9999-gentoo.patch ...

 * Failed Patch: numptyphysics-9999-gentoo.patch !
 *  ( /mnt/gentoo/portage/games-puzzle/numptyphysics/files/numptyphysics-9999-gentoo.patch )
 * 
 * Include in your bugreport the contents of:
 * 
 *   /var/tmp/portage/games-puzzle/numptyphysics-9999/temp/numptyphysics-9999-gentoo.patch.out

 * ERROR: games-puzzle/numptyphysics-9999::gentoo failed (prepare phase):
 *   Failed Patch: numptyphysics-9999-gentoo.patch!
 * 
 * Call stack:
 *     ebuild.sh, line   93:  Called src_prepare
 *   environment, line 3789:  Called epatch '/mnt/gentoo/portage/games-puzzle/numptyphysics/files/numptyphysics-9999-gentoo.patch'
 *   environment, line 1562:  Called die
 * The specific snippet of code:
 *               die "Failed Patch: ${patchname}!";
 * 
 * If you need support, post the output of `emerge --info '=games-puzzle/numptyphysics-9999::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=games-puzzle/numptyphysics-9999::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/games-puzzle/numptyphysics-9999/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/games-puzzle/numptyphysics-9999/temp/environment'.
 * Working directory: '/var/tmp/portage/games-puzzle/numptyphysics-9999/work/numptyphysics-9999'
 * S: '/var/tmp/portage/games-puzzle/numptyphysics-9999/work/numptyphysics-9999'

Hope my small criticism is constructive, and may help. Thanks to everyone working on gentoo for delivering a so nice and flexible distro.

[Comment 1 Samuel Bauer 2015-11-28 18:40:50 UTC]

Created attachment 418082 [details]
numptyphysics-9999-gentoo.patch.out

Missed attaching patch.out

[Comment 2 Mr. Bones. (RETIRED) 2015-11-30 17:35:11 UTC]

should be fixed.  thanks for the bug report.

[Comment 3 globus 2017-04-17 08:10:51 UTC]

Created attachment 470210 [details]
New patch out

[Comment 4 globus 2017-04-17 08:13:03 UTC]

Hello, sorry my bad English.
The same

Failed Patch: numptyphysics-9999-gentoo.patch !
 *  ( /usr/portage/games-puzzle/numptyphysics/files/numptyphysics-9999-gentoo.patch )

[Comment 5 Samuel Bauer 2018-01-06 14:45:01 UTC]

Created attachment 513516 [details]
numptyphysics-9999.ebuild

Hi, as already said before, patch are not as flexible as sed concerning live ebuild.
As a consequence, quite any time I try to build numptyphysics from the gentoo tree, it fails.
Even sed lines has sometimes to be changed, in this case upstream added definitions to CXXFLAGS.

[Comment 6 Samuel Bauer 2018-01-06 14:48:07 UTC]

Created attachment 513520 [details]
numptyphysics-0.3.4.ebuild

As a consequence I also send a release version of the ebuild which admit the "buggy" live patch as an entry.

I'll also move the ebuild to EAPI later.

[Comment 7 Pacho Ramos 2018-05-01 13:29:30 UTC]

This also needs to stop using games.eclass

[Comment 8 Samuel Bauer 2018-05-02 23:29:18 UTC]

Created attachment 529488 [details]
numptyphysics-9999.ebuild

live ebuild: Dropped games eclass, and use eapi 6

[Comment 9 Samuel Bauer 2018-05-03 00:01:47 UTC]

Created attachment 529492 [details]
numptyphysics-0.3.4-r1.ebuild

[Comment 10 Samuel Bauer 2018-05-03 00:04:58 UTC]

Created attachment 529494 [details, diff]
files/numptyphysics-0.3.4-gentoo.patch

updated patch

[Comment 11 Pacho Ramos 2018-05-27 16:10:31 UTC]

[master ac964cca6f73] games-puzzle/numptyphysics: Add 0.3.4,fix 9999 (#567036 by Samuel BAUER)
 4 files changed, 123 insertions(+), 26 deletions(-)
 create mode 100644 games-puzzle/numptyphysics/files/numptyphysics-0.3.4-gentoo.patch
 create mode 100644 games-puzzle/numptyphysics/numptyphysics-0.3.4.ebuild