Summary: | sci-biology/foldingathome: references PORTDIR in pkg_setup() where it is a PMS violation | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Michał Górny <mgorny> |
Component: | Current packages | Assignee: | Ian Stakenvicius (RETIRED) <axs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | esigra, licenses, qa, sci-biology, tsmksubc |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 373349 |
Description
Michał Górny
2015-11-21 17:48:47 UTC
The "license" does need to be displayed. However, this cat "${PORTDIR}" line is really just there as a convenience; I can just reproduce it in pkg_setup and ensure it's kept in sync with the file in licenses/ instead. I know that it needs to be displayed. However, I'm wondering if it needs to go into LICENSE as well -- but I guess it's better that way for consistency. As for displaying it, either inline it or move it to one of src_* phases. I'd personally prefer the former to reduce uses of PORTDIR. However, EAPI 7 may introduce LICENSEDIR for this, depending on the results of the discussion I just requested. commit 0b358efe8ef86e9410477fd9f4d298ef97737944 Author: Ian Stakenvicius <axs@gentoo.org> Date: Fri Apr 21 10:53:55 2017 -0400 sci-biology/foldingathome: fix use of $PORTDIR in phase function Bug: http://bugs.gentoo.org/566402 |