| Summary: | app-emulation/vmware-modules-304.2 with kernel 4.3 /var/tmp/portage/app-emulation/vmware-modules-304.2/work/vmmon-only/linux/driver.c:403:8: error: void value not ignored as it ought to be if (misc_deregister(&linuxState.misc)) { | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Ognian Tenchev <drJeckyll> |
| Component: | [OLD] Unspecified | Assignee: | Gentoo VMWare Bug Squashers [disabled] <vmware+disabled> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | darkcircle.0426, eugene.shalygin, gentoo3, Manfred.Knick |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
build.log
304-4.3-01-misc_deregister.patch marked function definition macro as description for linux kernel 4.3 or later. |
||
|
Description
Ognian Tenchev
2015-11-07 07:49:40 UTC
Created attachment 416214 [details]
build.log
According to https://lkml.org/lkml/2015/7/30/815 : -int misc_deregister(struct miscdevice *misc) +void misc_deregister(struct miscdevice *misc) So in vmware-modules-304.2 there two places where result matter, but both are just for logging. I will attach patch which just ignore there and make vmware-modules compile with kernel 4.3 Created attachment 416216 [details, diff]
304-4.3-01-misc_deregister.patch
is here someone who has smp related function define issue?
I've got an error like below message,
In file included from /var/tmp/portage/app-emulation/vmware-modules-304.2/work/vmmon-only/linux/hostif.c:101:0:
/var/tmp/portage/app-emulation/vmware-modules-304.2/work/vmmon-only/linux/hostif.c: In function ‘HostIF_CallOnEachCPU’:
/var/tmp/portage/app-emulation/vmware-modules-304.2/work/vmmon-only/linux/vmmonInt.h:34:50: error: too many arguments to function ‘smp_call_function’
#define compat_smp_call_function(fn, info, wait) smp_call_function(fn, info, 1, wait)
^
/var/tmp/portage/app-emulation/vmware-modules-304.2/work/vmmon-only/linux/hostif.c:2849:10: note: in expansion of macro ‘compat_smp_call_function’
(void)compat_smp_call_function(*func, data, 1);
^
In file included from /usr/src/linux-4.3.0-gentoo/include/linux/topology.h:33:0,
from /usr/src/linux-4.3.0-gentoo/include/linux/gfp.h:8,
from /usr/src/linux-4.3.0-gentoo/include/linux/mm.h:9,
from /var/tmp/portage/app-emulation/vmware-modules-304.2/work/vmmon-only/./include/compat_page.h:23,
from /var/tmp/portage/app-emulation/vmware-modules-304.2/work/vmmon-only/linux/hostif.c:32:
/usr/src/linux-4.3.0-gentoo/include/linux/smp.h:95:5: note: declared here
int smp_call_function(smp_call_func_t func, void *info, int wait);
^
/usr/src/linux-4.3.0-gentoo/scripts/Makefile.build:258: recipe for target '/var/tmp/portage/app-emulation/vmware-modules-304.2/work/vmmon-only/linux/hostif.o' failed
make[3]: *** [/var/tmp/portage/app-emulation/vmware-modules-304.2/work/vmmon-only/linux/hostif.o] Error 1
make[3]: *** Waiting for unfinished jobs....
In file included from /var/tmp/portage/app-emulation/vmware-modules-304.2/work/vmmon-only/linux/driver.c:69:0:
/var/tmp/portage/app-emulation/vmware-modules-304.2/work/vmmon-only/linux/driver.c: In function ‘LinuxDriverSyncCallOnEachCPU’:
/var/tmp/portage/app-emulation/vmware-modules-304.2/work/vmmon-only/linux/vmmonInt.h:34:50: error: too many arguments to function ‘smp_call_function’
#define compat_smp_call_function(fn, info, wait) smp_call_function(fn, info, 1, wait)
^
/var/tmp/portage/app-emulation/vmware-modules-304.2/work/vmmon-only/linux/driver.c:1246:4: note: in expansion of macro ‘compat_smp_call_function’
compat_smp_call_function(LinuxDriverSyncCallHook, &args, 0);
^
In file included from /usr/src/linux-4.3.0-gentoo/include/linux/percpu.h:6:0,
from /usr/src/linux-4.3.0-gentoo/include/linux/percpu-rwsem.h:6,
from /usr/src/linux-4.3.0-gentoo/include/linux/fs.h:30,
from /usr/src/linux-4.3.0-gentoo/include/linux/highmem.h:4,
from /var/tmp/portage/app-emulation/vmware-modules-304.2/work/vmmon-only/linux/driver.c:25:
/usr/src/linux-4.3.0-gentoo/include/linux/smp.h:95:5: note: declared here
int smp_call_function(smp_call_func_t func, void *info, int wait);
and I made simple patch.
Created attachment 416598 [details, diff]
marked function definition macro as description for linux kernel 4.3 or later.
eliminate an error message related on
error: too many arguments to function ‘smp_call_function’
(In reply to Ognian Tenchev from comment #3) > Created attachment 416216 [details, diff] [details, diff] > 304-4.3-01-misc_deregister.patch Same issue with latest Linux 4.3.2 (no surprise) Emerged from scratch, I needed to apply also patches from https://bugs.gentoo.org/show_bug.cgi?id=561252 in order to make compilation proceed I haven't met the problem reported by Seong-ho, Ognian's patch alone solved Yep, 4.2 patches are needed for 4.3 plus this patch. I also have not reach Seong-ho Cho issue. (In reply to Ognian Tenchev from comment #7) > Yep, 4.2 patches are needed for 4.3 plus this patch. I also have not reach > Seong-ho Cho issue. This should be fixed in 304.3-r1. Please re-open / shout if you still have problems. |
