Summary: | app-text/openlp-2.4.1 version bump | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jaak Ristioja <jaak> |
Component: | Current packages | Assignee: | Jory A. Pratt <anarchy> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | gentoo |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
URL: | https://openlp.org/blog/2016/06/26/openlp-242-released | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
ebuild for app-text/openlp-2.4.2
Script to startup openlp under python3. openlp-2.4.2 ebuild basics OpenLP-2.4.2 dep correction v2 OpenLP-2.4.2 v3 Patch to ebuild to rename openlp.py to openlp in /usr/bin |
Description
Jaak Ristioja
2015-11-03 08:20:59 UTC
Meanwhile, they've already managed to reach version 2.4.1. Created attachment 443400 [details] ebuild for app-text/openlp-2.4.2 This is an ebuild I put together for installing openlp-2.4.2. It has issues, but worksforme. This was created using hints from https://forums.gentoo.org/viewtopic-t-1035816-highlight-openlp+ebuild.html. Issue include that I'm not handling the tests properly, and I'm not sure the way I install my sh script is proper. Created attachment 443402 [details]
Script to startup openlp under python3.
This needs to be put in the portage files directory for app-text/openlp for the ebuild to find.
(In reply to Peter Fox from comment #2) > Created attachment 443400 [details] > ebuild for app-text/openlp-2.4.2 > > This is an ebuild I put together for installing openlp-2.4.2. It has issues, > but worksforme. This was created using hints from > https://forums.gentoo.org/viewtopic-t-1035816-highlight-openlp+ebuild.html. > Issue include that I'm not handling the tests properly, and I'm not sure the > way I install my sh script is proper. Ebuild is fine, even way you install the python script is fine. Only issue I see is deps need to be locked to appropriate versions. (In reply to Peter Fox from comment #3) > Created attachment 443402 [details] > Script to startup openlp under python3. > > This needs to be put in the portage files directory for app-text/openlp for > the ebuild to find. #!/usr/bin/env python3 is already defined by openlp.py so there really is no need for the custom startup script. (In reply to Jory A. Pratt from comment #4) > (In reply to Peter Fox from comment #2) > > Created attachment 443400 [details] > > ebuild for app-text/openlp-2.4.2 > > > > This is an ebuild I put together for installing openlp-2.4.2. It has issues, > > but worksforme. This was created using hints from > > https://forums.gentoo.org/viewtopic-t-1035816-highlight-openlp+ebuild.html. > > Issue include that I'm not handling the tests properly, and I'm not sure the > > way I install my sh script is proper. > > Ebuild is fine, even way you install the python script is fine. Only issue I > see is deps need to be locked to appropriate versions. Verifying version of modules... PyQt5 >= 5.0 ... FAIL Qt5 >= 5.0 ... FAIL sqlalchemy >= 0.5 ... FAIL enchant >= 1.3 ... FAIL You can check the deps via the script in scripts directory Created attachment 445180 [details]
openlp-2.4.2 ebuild basics
This has proper deps and makes the appropriate adjustment for openlp.py symlink please test and let me know your results.
Created attachment 445182 [details]
OpenLP-2.4.2 dep correction v2
Sorry had to fix a few flaws.
Created attachment 445184 [details]
OpenLP-2.4.2 v3
More dep fixes. I am working on fixing the build system for tests, soon as I finish it will push it to tree. I will get with a member of python team to assist me so we can wrap this up, but will be sometime tomorrow evening before I can make that happen.
https://cgit.gentoo.org/dev/anarchy.git/ please find the current work there. I have everything basically going to the correct location now and tests are fixed. I have not had a chance to fully test it. Please feel free to test it and report and problems/patches against it so we can get this resolved for you all. I've tried your ebuild, and get:
$ openlp
Traceback (most recent call last):
File "<frozen importlib._bootstrap>", line 2218, in _find_and_load_unlocked
AttributeError: 'module' object has no attribute '__path__'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/bin/openlp", line 27, in <module>
from openlp.core.common import is_win, is_macosx
File "/usr/bin/openlp.py", line 27, in <module>
from openlp.core.common import is_win, is_macosx
ImportError: No module named 'openlp.core'; 'openlp' is not a package
I'm running python 3.4:
$ python
Python 3.4.3 (default, Apr 17 2016, 14:14:46)
[GCC 4.9.3] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> q
The problem appears to be the linking of /usr/bin/openlp to /usr/bin/openlp.py. The installer should rename /usr/bin/openlp.py to /usr/bin/openlp instead. The import command is picking up openlp.py in /usr/bin which is never going to work. Created attachment 445314 [details, diff]
Patch to ebuild to rename openlp.py to openlp in /usr/bin
Works for me with this patch.
(In reply to Peter Fox from comment #13) > Created attachment 445314 [details, diff] [details, diff] > Patch to ebuild to rename openlp.py to openlp in /usr/bin > > Works for me with this patch. Thank you for your contribution, I have it in my dev overlay just testing a few things and will push it to both my overlay and main tree. I did have to add the dev-python/alembic dep as well. Thanks once again for everyones help. It has landed on the tree and should populate out to the mirrors shortly. |