Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 564490

Summary: [Future EAPI] allow =sys-kernel/gentoo-sources-4.1.* handling
Product: Gentoo Hosted Projects Reporter: Pacho Ramos <pacho>
Component: PMS/EAPIAssignee: PMS/EAPI <pms>
Status: RESOLVED DUPLICATE    
Severity: normal CC: esigra
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 174380, 598525    

Description Pacho Ramos gentoo-dev 2015-10-30 12:17:59 UTC
Currently, I want to keyword all 4.1.x release but NOT all 4.1* (like a future 4.10.x that could appear). What is the way of allowing that? It seems that is not allowed for some reason :(

--- Invalid atom in /etc/portage/package.keywords/zz: =sys-kernel/gentoo-sources-4.1.*


Thanks a lot
Comment 1 Zac Medico gentoo-dev 2015-10-30 16:02:19 UTC
Since portage-2.2.20, 4.1* behaves as you want:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=d4966a381ee4577818bd972946647338046715b1

*** This bug has been marked as a duplicate of bug 560466 ***
Comment 2 Pacho Ramos gentoo-dev 2015-11-03 21:25:33 UTC
And, what is wrong with 4.1.* form? It looks much more intuitive to me and I am not sure why it's not allowed :/
Comment 3 Zac Medico gentoo-dev 2015-11-03 21:37:33 UTC
(In reply to Pacho Ramos from comment #2)
> And, what is wrong with 4.1.* form? It looks much more intuitive to me and I
> am not sure why it's not allowed :/

There's nothing wrong with it, except that it's invalid according to PMS.
Comment 4 Zac Medico gentoo-dev 2015-11-03 21:39:38 UTC
Of course, we could extend the syntax in a future EAPI.
Comment 5 Pacho Ramos gentoo-dev 2015-11-03 21:40:37 UTC
(In reply to Zac Medico from comment #4)
> Of course, we could extend the syntax in a future EAPI.

Should I reopen this then? Thanks :)
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-11-03 22:03:55 UTC
I would expect 4.1.* to match 4.1.x but not 4.1. Is that what you expect?
Comment 7 Pacho Ramos gentoo-dev 2015-11-03 22:10:02 UTC
MAybe I am forgetting some case... but the cases I remember should be covered with that as they will have x.y.0 versions too
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-10-30 12:05:56 UTC
Let me ask a different question: is there a specific use case for x.* that would be distinct from x*?

Remember that x* accepts any values for the components following x, not a wildcard of x*; e.g. 4.1* matches 4.1_rc1, 4.1, 4.1.0, 4.1.1...

I'm rather opposed to having additional wildcard-thingie with different behavior unless absolutely necessary, and I'd rather not get into specific version separators that are bound to produce even more confusion.
Comment 9 Ulrich Müller gentoo-dev 2016-10-30 12:20:33 UTC
IMHO the confusion arising from a 4.1.* wildcard matching 4.1.1 and 4.1.2 but not 4.1 and 4.1_p1 would outweigh any benefit.

Consequently we should also have 4.1_* then, for matching 4.1_pre1 and 4.1_p1?
Comment 10 Pacho Ramos gentoo-dev 2016-11-16 16:36:38 UTC
(In reply to Ulrich Müller from comment #9)
> IMHO the confusion arising from a 4.1.* wildcard matching 4.1.1 and 4.1.2
> but not 4.1 and 4.1_p1 would outweigh any benefit.

I do not think there would be much confusion... if you see a dep like 4.1.* , we will expect it to not cover 4.1 (without the last dot). This would cover lots of upstream versioning systems that, when they are relying on three numbers, they use to release 4.1.0 versions instead of plain 4.1

Also, the downside of not covering a 4.1 version looks softer to me than implicitly covering all 4.1 versions, all 4.10, 4.11, 4.11... and anything the 4.1* construct will force us to handle
Comment 11 Ulrich Müller gentoo-dev 2016-11-16 20:01:37 UTC
(In reply to Pacho Ramos from comment #10)
> Also, the downside of not covering a 4.1 version looks softer to me than
> implicitly covering all 4.1 versions, all 4.10, 4.11, 4.11... and anything
> the 4.1* construct will force us to handle

4.1* does _not_ match 4.10 or 4.11. We fixed that some time ago, see bug 560466.
Comment 12 Simon 2018-09-28 10:10:05 UTC
I'm aware this is an old issue, but it seems to be related to my question.

Why don't the kernels just use a slot for the "main" version like 4.14, 4.15, etc and subslots for the (bug)fix releases? That seems like quiet a natural fit? Or is there something that prevents this from working properly?
Comment 13 Ulrich Müller gentoo-dev 2019-03-04 08:09:00 UTC
Closing per comment #11.

*** This bug has been marked as a duplicate of bug 560466 ***