Bug 563876

Summary:	Failed to update file modify time on fetched binary packages from FTP
Product:	Portage Development	Reporter:	Mike Hiretsky <mh>
Component:	Binary packages support	Assignee:	Portage team <dev-portage>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	InVCS
Priority:	Normal
Version:	2.2
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Change key MTIME to _mtime_

Description Mike Hiretsky 2015-10-23 13:20:30 UTC

Portage does not use already fetched from binhost tbz2 files. Probably portage does not fix mtime for fetched tbz2 files.

Reproducible: Always

Steps to Reproduce:
1. Set any ftp binhost
2. emerge app-misc/mc
3. emerge app-misc/mc
Actual Results:  
Refetching binary tbz2 

Expected Results:  
Will be used already fetched tbz2

I use sys-apps/portage-2.2.20.1.

At this commit will 

https://github.com/gentoo/portage/commit/328dd4712f88cbb8ef390ae9eb471afa1ef781d7

-				remote_mtime = bintree._remotepkgs[self.pkg.cpv].get("MTIME")
+				remote_mtime = bintree._remotepkgs[
+					bintree.dbapi._instance_key(
+					self.pkg.cpv)].get("MTIME")

_bintree.remotepkgs has not MTIME key, but has _mtime_.

Comment 1 Mike Hiretsky 2015-10-23 13:30:50 UTC

Created attachment 415250 [details, diff]
Change key MTIME to _mtime_

Comment 2 Zac Medico gentoo-dev

2015-10-23 16:27:40 UTC

Thanks, this is in git:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=0ebfaaa9b65b935ae4eba67e97495aa26e913f8c

Comment 3 Mike Hiretsky 2015-10-26 11:05:40 UTC

Thank you, it works.

Comment 4 Zac Medico gentoo-dev

2016-03-14 04:03:47 UTC

Fixed in 2.2.24.