Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 563092

Summary: repoman should reject ebuilds that are not UTF8 encoded
Product: Portage Development Reporter: SpanKY <vapier>
Component: RepomanAssignee: Portage team <dev-portage>
Status: RESOLVED WONTFIX    
Severity: enhancement    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=563094
Whiteboard:
Package list:
Runtime testing required: ---

Description SpanKY gentoo-dev 2015-10-15 03:01:11 UTC
to prevent mistakes in encoding, we should reject ebuilds that do not decode as utf8.  i think we already do this for metadata.xml, but we should expand it.

i would also like to see it apply to patches, but since we have to patch upstream files that not might be utf8 encoded, we can't enforce it there easily :(.
Comment 1 SpanKY gentoo-dev 2015-10-15 14:31:32 UTC
in fact, PMS already requires ebuilds be UTF8 encoded :)

Ebuild File Format
...  The file encoding must be UTF-8 with Unix-style newlines. ...
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-12 03:18:39 UTC
repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-12 03:32:21 UTC
pkgcheck has InvalidUTF8. Not sure if it's sufficient.