Summary: | sys-block/open-iscsi: should not depend on virtual/udev | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jakub Jirutka <jakub> |
Component: | [OLD] Core system | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | reviewers+disabled |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/gentoo/gentoo/pull/209 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Jakub Jirutka
2015-10-14 21:50:26 UTC
If udev is a runtime-optional then it shouldn't even be in RDEPEND, but just be printed via elog in pkg_postinst(). Also, I think those files could be installed unconditionally, so there's no reason for an udev flag at all IMO. Let me rephrase what hasufell said. Is there ever any reason to disable udev rules here? If there is, the patch looks acceptable to me. If there's not, we shouldn't have USE=udev and it'd be fine just to remove udev dependency... well, since it's more of a reverse dependency. the udev rules are only used to probe devices automatically, so there's no need to depend on it http://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f2c1a8a62739b9cbbcb05c8af541383cdb1caa4f |