Summary: | sys-apps/portage-2.2.21 ignores PORTAGE_RSYNC_EXTRA_OPTS | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Holger Hoffstätte <holger> |
Component: | Core | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bkohler |
Priority: | Normal | Keywords: | InVCS, REGRESSION |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://archives.gentoo.org/gentoo-user/message/5b17296c9860d24f22a99c3fada9600c | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 549914 |
Description
Holger Hoffstätte
2015-09-23 09:52:05 UTC
The only change between those 2 versions was the added capability to specify those in your repos.conf file. In that way you can set them differently for each repo. But the default was to use the make.conf setting if the repos.conf one was not defined. (In reply to Brian Dolbec from comment #1) > The only change between those 2 versions was the added capability to specify > those in your repos.conf file. In that way you can set them differently for > each repo. I thought as much and was wondering if that was now the only supported way, hence the question on the -user list. If it is - and one could argue that the global fallback is no longer needed or necessary with per-repo configurations - I'd be fine with that; just wanted to clarify whether the fallback is still supposed to work, which it apparently should. All that being said, adding the option to the repo conf does not seem to work either: sync-rsync-extra-opts = "--old-compress --exclude-from=/etc/portage/rsync_excludes" will still download stuff I excluded. So it seems the regression is not just in handling the fallback from repo to global config, but in not considering extra rsync opts at all. I see the same problem, neither PORTAGE_RSYNC_EXTRA_OPTS in make.conf nor sync-rsync-extra-opts in repos.conf is applied. For testing purposes I'm passing "--nonsense" as an extra option... in 2.2.20.1 of course it errors out immediately, 2.2.21 happily starts the sync. Where is this new option for repos.conf documented? I cannot find anything in RELEASE-NOTES or any of the normal documentation this is fixed in git commit: https://gitweb.gentoo.org/proj/portage.git/commit/id=cda13bc9bb42ae1c91b317711365573a2d3695f3 (In reply to Ben Kohler from comment #3) > I see the same problem, neither PORTAGE_RSYNC_EXTRA_OPTS in make.conf nor > sync-rsync-extra-opts in repos.conf is applied. For testing purposes I'm > passing "--nonsense" as an extra option... in 2.2.20.1 of course it errors > out immediately, 2.2.21 happily starts the sync. > > Where is this new option for repos.conf documented? I cannot find anything > in RELEASE-NOTES or any of the normal documentation it is listed in the portage man page, the repos.conf sub-section. <quote> sync-rsync-extra-opts Extra options to give to rsync on repository synchronization. It takes precedence over a decla‐ ration in [DEFAULT] section, that takes precedence over PORTAGE_RSYNC_EXTRA_OPTS. </quote> Released in portage-2.2.22 |