Summary: | New submission: leafnode-1.9.19 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Markus Krainer <mkrainer> |
Component: | New packages | Assignee: | chouser (RETIRED) <chouser> |
Status: | VERIFIED FIXED | ||
Severity: | enhancement | CC: | mkrainer |
Priority: | High | ||
Version: | 1.0 RC6 r14 | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | leafnode-1.9.19 |
Description
Markus Krainer
2002-02-06 13:09:43 UTC
Created attachment 132 [details]
leafnode-1.9.19
This line in the ebuild intruiged me: # <dollar_sign>Header<dollar_sign> Did you using some unusual tool to create the ebuild? I took out the --infodir line, since this package doesn't contain any info files. Also, I like having error messages on all the "die" lines. I added DEBUG="$CFLAGS" on the emake command-line, otherwise the Makefile ignores make.conf's CFLAGS' I moved the creation of all the spool dirs into pkg_postinst(), so that they don't get removed on unmerge. Otherwise, quite a beautiful ebuild. Please test this again, if you can -- I don't know enough about news to test it well enough. Thanks! --Chouser Thanks for your detailed description of the mistakes I made in my first ebuild. As I have some more ebuilds in planning this is a valuable source of information for me. I tested it again (merge/unmerge/remerge) and it works perfectly. Please note my comments below: > ------- Additional Comments From chouser@gentoo.org 2002-02-24 21:24 ------- > This line in the ebuild intruiged me: > > # <dollar_sign>Header<dollar_sign> I thought this gets replaced by cvs. > Did you using some unusual tool to create the ebuild? If vim is unusual ;) > I took out the --infodir line, since this package doesn't contain any info > files. Also, I like having error messages on all the "die" lines. > > I added DEBUG="$CFLAGS" on the emake command-line, otherwise the Makefile > ignores make.conf's CFLAGS' Sorry, I overlooked that. > I moved the creation of all the spool dirs into pkg_postinst(), so that they > don't get removed on unmerge. That's great! I didn't know how to accomplish this. > Otherwise, quite a beautiful ebuild. Please test this again, if you can -- I > don't know enough about news to test it well enough. Thanks! Thanks, too! Markus |