Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 560862

Summary: kde-frameworks/kdesu-5.13.0 fails to build with musl
Product: Gentoo Linux Reporter: Vic Kerr (wikky) <wikky>
Component: [OLD] KDEAssignee: Gentoo KDE team <kde>
Status: RESOLVED FIXED    
Severity: normal CC: musl, wikky
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://git.reviewboard.kde.org/r/127415/
Whiteboard: Fixed in 5.21
Package list:
Runtime testing required: ---
Attachments: Proposed patch for ::musl
Add kdesu-5.19.0 to ::musl

Description Vic Kerr (wikky) 2015-09-19 19:25:07 UTC
Kdesu does not define the required feature macros for the functions it uses. It builds on glibc (by accident, since the *glibc* man pages specify those macros), but does not build on musl.
Comment 1 Manuel Rüger (RETIRED) gentoo-dev 2015-09-19 19:26:57 UTC
Have you filed a bug upstream about this?
Comment 2 Vic Kerr (wikky) 2015-09-19 19:35:05 UTC
Created attachment 412294 [details, diff]
Proposed patch for ::musl

Add the needed feature macros.
Comment 3 Vic Kerr (wikky) 2015-09-19 19:43:42 UTC
(In reply to Manuel Rüger from comment #1)
> Have you filed a bug upstream about this?

No, not yet. I've added a patch for the musl overlay, which collects musl-related issues. I'll notify upstream.
Comment 4 Michael Palimaka (kensington) gentoo-dev 2015-09-20 15:08:42 UTC
Since you have a patch, better to go straight to reviewboard: http://git.reviewboard.kde.org/
Comment 5 Johannes Huber (RETIRED) gentoo-dev 2016-03-11 13:31:55 UTC
(In reply to Wiktor W Brodlo from comment #3)
> (In reply to Manuel Rüger from comment #1)
> > Have you filed a bug upstream about this?
> 
> No, not yet. I've added a patch for the musl overlay, which collects
> musl-related issues. I'll notify upstream.

What is the status here?
Comment 6 Vic Kerr (wikky) 2016-03-18 00:50:54 UTC
(In reply to Johannes Huber from comment #5)
> What is the status here?

I've posted a more correct patch to the upstream reviewboard[0]. Until it gets merged into upstream, I'm posting an updated patch that adds kdesu-5.19.0 to ::musl below.

[0] https://git.reviewboard.kde.org/r/127415/
Comment 7 Vic Kerr (wikky) 2016-03-18 00:51:59 UTC
Created attachment 428478 [details, diff]
Add kdesu-5.19.0 to ::musl
Comment 8 Vic Kerr (wikky) 2016-03-20 10:42:54 UTC
The patch has been accepted upstream.
Comment 9 Johannes Huber (RETIRED) gentoo-dev 2016-03-20 20:58:32 UTC
Confirmed by upstream