Summary: | Building dev-scheme/guile-1.8.8 with gcc-5 breaks anything using guile-snarf (i.e.: dev-scheme/guile-cairo-1.9.91, x11-libs/guile-gtk-2.1-r2) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Greg Turner <gmt> |
Component: | [OLD] GCC Porting | Assignee: | Scheme Project <scheme> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugzie, gmt, rhill |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 536984 | ||
Attachments: |
guile-1.8.8-gcc5.patch
fix-bug-560736-v2.patch |
Description
Greg Turner
2015-09-17 23:43:21 UTC
*** Bug 553098 has been marked as a duplicate of this bug. *** Created attachment 412158 [details, diff]
guile-1.8.8-gcc5.patch
Created attachment 412220 [details, diff] fix-bug-560736-v2.patch (In reply to Ryan Hill from comment #2) > Created attachment 412158 [details, diff] [details, diff] > guile-1.8.8-gcc5.patch patch W4M... well, almost*. -- * I had to re-implement the patch by hand to make it apply; the difference was sufficiently subtle I had to diff the diffs to notice it -- compared to mine, Ryan's patch appends (in pseudo-ascii): [lots of whitespace]# writes stdout to the hunk header: @@ -50,7 +50,7 @@ modern_snarf () I found this to be quite surprising -- I always thought that part of a patch was for human consumption only and otherwise ignored. Guess I was wrong. I surmise that the "# writes stdout" comment must be generated during eautoreconf, as my go-to mechanism for wedging patches into 3rd-party ebuilds occurs during post_src_unpack (Ryan presumably generated his patch by running "ebuild ... src_prepare" and hacking on the resulting ${WORKDIR}). Anyhow, assuming the epatch statement goes into the compound epatch statement that is currently the first line of src_prepare() in guile-1.8.8-r1.ebuild (and that my surmises are all spot-on), Ryan's patch apparently won't apply. My re-diff-ification is enclosed. (In reply to Ryan Hill from comment #2) > Created attachment 412158 [details, diff] [details, diff] > guile-1.8.8-gcc5.patch By the way, I forgot to mention, thanks! If this fix wasn't your own invention, Ryan, I sure wasn't able to make it issue forth from the Googles. That's weird. I have it applying right after the gcc46 patch and I'm not seeing any problems. It was made on a src_unpack-ed tree. I think as of patch 2.7 it started paying attention to stuff in the patch headers to better support some git-style diff features. Maybe we're seeing some interaction with that. I'll drop it to be safe. Fixed in 1.8.8-r2. |