| Summary: | dev-libs/libedit: patch to build under musl (ISO10646) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | toast+misc |
| Component: | [OLD] Library | Assignee: | Gentoo musl team <musl> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bsd+disabled |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://bugs.gentoo.org/show_bug.cgi?id=870001 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 430702 | ||
| Attachments: | Patch to ::musl to fix the issue described above | ||
Thanks this is committed to the musl overlay. We'll leave the bug IN_PROGRESS so we'll remember to remove the patch when 1.1.12 comes out. Musl hit 1.1.12, but the problem is not solved. Moreover, since the patch checks for musl version <1.1.12 the patch will probably stop working (fix is trivial, however). With musl 1.1.14 (and gcc -999) issue still persists without patch. sys-libs/musl-1.1.15 has now stdc-predef.h and is stable. Does libedit now compile fine without patches? dev-libs/libedit-20130712.3.1::gentoo compiles and installs fine. Closing bug. |
Created attachment 411630 [details] Patch to ::musl to fix the issue described above Libedit uses the __STDC_ISO_10646__ macro to verify that the first 127 code points of wchar_t are not assumed to be ascii-compatible. This macro must be defined before any headers are included. Musl is not yet using stdc-predef.h functionality provided by gcc >4.8. Support for it is planned during the next release cycle (1.1.12). This patch adds the latest ebuild of libedit, with -r99, which checks for ELIBC being musl, and for its version to be <1.1.12, in which case we add -D__STDC_ISO_10646__=201103L to cppflags. It is notable that this does require gcc 4.8+ to work, but as far as I know that should be handled by the implicit dependency system; if not adding a check for that may be necessary (probably comparing best_version with $CC?)