Summary: | net-nntp/pan: crash when built with gcc-5.2 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Holger Hoffstätte <holger> |
Component: | Current packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | PATCH |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://thread.gmane.org/gmane.comp.gnome.apps.pan.user/14925 | ||
See Also: | https://bugzilla.gnome.org/show_bug.cgi?id=754698 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 536984 | ||
Attachments: | Suggested fix to enforce the old std::string ABI |
Description
Holger Hoffstätte
2015-09-05 13:49:53 UTC
Created attachment 411056 [details, diff]
Suggested fix to enforce the old std::string ABI
(In reply to Holger Hoffstätte from comment #1) No. We are not going to put bandaids on upstream's lack of experience with c++ by forcing a particular implementation of libstdc++ that happens to make pan not crash by lucky accident. This needs to be fixed properly. Fixed in pan-0.139-r1 Patch submitted upstream at https://bugzilla.gnome.org/show_bug.cgi?id=754698 Please test! https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3e828ee766a6ebaa5c71ed1764f7998d59c24054 commit 3e828ee766a6ebaa5c71ed1764f7998d59c24054 Author: Alexandre Rostovtsev <tetromino@gentoo.org> Date: Mon Sep 7 13:29:52 2015 -0400 net-nntp/pan: fix newsrc-* files created in wrong place with g++-5 Gentoo-Bug: 559666 Reported-by: Holger Hoffstätte Upstream-Bug-url: https://bugzilla.gnome.org/show_bug.cgi?id=754698 Package-Manager: portage-2.2.20.1 Thanks for this proper fix; I hadn't looked at the code yet. After seeing your patch I agree that returning a reference to a static string is the right thing to do here. Upgraded to -r1 and it seems to be working fine so far. |