Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 55816

Summary: net-firewall/shorewall-2.0.3a: ambiguous redirect
Product: Gentoo Linux Reporter: Ioannis Aslanidis (RETIRED) <deathwing00>
Component: New packagesAssignee: Martin Holzer (RETIRED) <mholzer>
Status: VERIFIED FIXED    
Severity: normal CC: epyon9283, steven
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Ioannis Aslanidis (RETIRED) gentoo-dev 2004-07-01 11:37:23 UTC
# /etc/init.d/shorewall restart

 * Please use 'svc_stop; svc_start' and not 'start; stop' to
 * restart the service in its custom 'restart()' function.
 * Run shorewall without arguments for more info.

 * Stopping firewall...
/usr/share/shorewall/firewall: line 112: $RESTOREBASE: ambiguous redirect
/usr/share/shorewall/firewall: line 113: $RESTOREBASE: ambiguous redirect
/usr/share/shorewall/firewall: line 114: $RESTOREBASE: ambiguous redirect
/usr/share/shorewall/firewall: line 125: $RESTOREBASE: ambiguous redirect                                                    [ ok ]
 * Starting firewall...                         # 
# Write a progress_message command to $RESTOREBASE
#
save_progress_message()
{

    echo                           >> $RESTOREBASE
    echo "progress_message \"$@\"" >> $RESTOREBASE
    echo                           >> $RESTOREBASE
}

# 
# Save the passed command in the restore script then run it -- returns the status of the command
# If the command involves file redirection then it must be enclosed in quotes as in:
#
#     run_and_save_command "echo 1 > /proc/sys/net/ipv4/ip_forward"
#
run_and_save_command()
{
    echo "$@" >> $RESTOREBASE
    eval $*
}
                                                                             [ ok ]

---------------



Reproducible: Always
Steps to Reproduce:
1. /etc/init.d/shorewall stop
Comment 1 Ioannis Aslanidis (RETIRED) gentoo-dev 2004-07-01 11:40:01 UTC
My message got missformatted... repeating.

# /etc/init.d/shorewall restart

 * Please use 'svc_stop; svc_start' and not 'start; stop' to
 * restart the service in its custom 'restart()' function.
 * Run shorewall without arguments for more info.

 * Stopping firewall...
/usr/share/shorewall/firewall: line 112: $RESTOREBASE: ambiguous redirect
/usr/share/shorewall/firewall: line 113: $RESTOREBASE: ambiguous redirect
/usr/share/shorewall/firewall: line 114: $RESTOREBASE: ambiguous redirect
/usr/share/shorewall/firewall: line 125: $RESTOREBASE: ambiguous redirect                                                    [ ok ]
 * Starting firewall...                                                                                                      [ ok ]
---------------


# 
# Write a progress_message command to $RESTOREBASE
#
save_progress_message()
{

    echo                           >> $RESTOREBASE
    echo "progress_message \"$@\"" >> $RESTOREBASE
    echo                           >> $RESTOREBASE
}

# 
# Save the passed command in the restore script then run it -- returns the status of the command
# If the command involves file redirection then it must be enclosed in quotes as in:
#
#     run_and_save_command "echo 1 > /proc/sys/net/ipv4/ip_forward"
#
run_and_save_command()
{
    echo "$@" >> $RESTOREBASE
    eval $*
}
Comment 2 Martin Holzer (RETIRED) gentoo-dev 2004-07-02 03:48:06 UTC
i've just sent a mail to shorewall-users
Comment 3 Ioannis Aslanidis (RETIRED) gentoo-dev 2004-07-02 03:50:09 UTC
Fixed Upstream?
Comment 4 Martin Holzer (RETIRED) gentoo-dev 2004-07-05 02:09:51 UTC
Fixes two problems:

     * Error messages regarding $RESTOREBASE occur during shorewall stop.
     * If CLEAR_TC=Yes in shorewall.conf, shorewall stop fails without 
removing the lock file.

http://shorewall.net/pub/shorewall/shorewall-2.0.3c
ftp://shorewall.net/pub/shorewall/shorewall-2.0.3c
Comment 5 Martin Holzer (RETIRED) gentoo-dev 2004-07-07 03:08:13 UTC
2.0.3c works here

time to get into portage
Comment 6 Ioannis Aslanidis (RETIRED) gentoo-dev 2004-07-07 03:17:05 UTC
Right! Awaiting for CVS update.
Comment 7 Martin Holzer (RETIRED) gentoo-dev 2004-07-07 08:25:00 UTC
now in cvs

closing with 2.0.3c
Comment 8 Ioannis Aslanidis (RETIRED) gentoo-dev 2004-07-07 10:28:50 UTC
Nice work :)
Comment 9 Ioannis Aslanidis (RETIRED) gentoo-dev 2004-07-08 13:41:01 UTC
Martin, close the bug :)