| Summary: | sys-apps/portage: Manifest.write(): produce stable/predictable Manifest mtime for rsync | ||
|---|---|---|---|
| Product: | Portage Development | Reporter: | Zac Medico <zmedico> |
| Component: | Enhancement/Feature Requests | Assignee: | Portage team <dev-portage> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | InVCS |
| Priority: | Normal | ||
| Version: | 2.2 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.gentoo.org/show_bug.cgi?id=557192 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 567920 | ||
| Bug Blocks: | 549914 | ||
|
Description
Zac Medico
2015-08-16 21:12:32 UTC
There's a patch in the following branch: https://github.com/zmedico/portage/tree/bug_557962 I've posted it for review here: https://archives.gentoo.org/gentoo-portage-dev/message/eb907a3b724bfecfca4de2b80c99c624 This is in the master branch now: https://gitweb.gentoo.org/proj/portage.git/commit/?id=6dacd0ed9f6dc206f4932d42bbb36300f56e71f7 Alternative is to take the mtime of the parent dir, and retain that, including the dir itself, such as in: http://hg.code.sf.net/p/gentooprefixtree/code/rev/0679eab6c25f In any case, make sure you retain the mtime of the dir, else it will cause it to be rsync-ed every time as well, which is unnecessary. (In reply to Fabian Groffen from comment #3) > In any case, make sure you retain the mtime of the dir, else it will cause > it to be rsync-ed every time as well, which is unnecessary. The dir mtime should be irrelevant, since we added --omit-dir-times to PORTAGE_RSYNC_OPTS a couple of years ago: https://gitweb.gentoo.org/proj/portage.git/commit/?id=367bbdfdab866c00c0d826732d4672ed3863fa09 /etc/portage/repo.postsync.d/example correction: Released in portage-2.2.21 |