Summary: | [mysql] Ebuild failures occuring in global scope | ||
---|---|---|---|
Product: | Gentoo Infrastructure | Reporter: | Michał Górny <mgorny> |
Component: | Gentoo Overlays | Assignee: | Gentoo Linux MySQL bugs team <mysql-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://gentoo.github.io/repo-qa-check-results/mysql.html | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 552950 |
Description
Michał Górny
2015-08-15 08:06:54 UTC
Your script is flawed if it cannot find these inherits. Works fine in portage No, they're not. inherit java-pkg-2 java-ant-2 "${VCS_INHERIT}" This evaluates to inherit "" (".eclass") when VCS_INHERIT is unset. Portage bugs (like lack of quoting in random places) don't justify broken ebuilds. Tell me how this is not broken: !!! mariadb-java-client-9999.ebuild, line 23: Called inherit 'java-pkg-2' 'java-ant-2' 'eutils' 'git-r3' !!! ebuild-default-functions.lib, line 230: Called __internal_inherit 'java-pkg-2' !!! ebuild-daemon.lib, line 37: Called die !!! The die message: [FATAL] !!! unknown inherit command from pythonic side, 'gen_metadata 256' for eclass java-pkg-2 (In reply to Michał Górny from comment #2) > No, they're not. > > inherit java-pkg-2 java-ant-2 "${VCS_INHERIT}" > > This evaluates to inherit "" (".eclass") when VCS_INHERIT is unset. Portage > bugs (like lack of quoting in random places) don't justify broken ebuilds. So you would rather have 2 inherit commands which, as I understand it, is another QA no-no? (In reply to Brian Evans from comment #4) > (In reply to Michał Górny from comment #2) > > No, they're not. > > > > inherit java-pkg-2 java-ant-2 "${VCS_INHERIT}" > > > > This evaluates to inherit "" (".eclass") when VCS_INHERIT is unset. Portage > > bugs (like lack of quoting in random places) don't justify broken ebuilds. > > So you would rather have 2 inherit commands which, as I understand it, is > another QA no-no? There are numerous possibilities of solving this particular issue which require only a small amount of good will. Those include: 1. 2 inherit commands -- which are actually fine for non-ancient Package Managers, 2. non-quoted ${VCS_INHERIT} variable (which causes empty value not to be treated as parameter), 3. VCS_INHERIT as an array -- then "${VCS_INHERIT[@]}" could expand to zero parameters, 4. removing the live code from release ebuild :P. I guess I could find one or two more solutions if I tried hard but I guess that's not the point. Quotes removed from VCS_INHERITS and mysql-connector-python dropped as it is in the tree with a newer version. |