Bug 557086

Summary:	dev-vcs/gitg-3.16.1: compilation error with net-libs/webkit-gtk-2.8.3
Product:	Gentoo Linux	Reporter:	Łukasz Dubiel <bambucha14>
Component:	[OLD] GNOME	Assignee:	Mike Auty (RETIRED) <ikelos>
Status:	RESOLVED FIXED
Severity:	normal	CC:	gnome
Priority:	Normal
Version:	unspecified
Hardware:	AMD64
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build-log

Description Łukasz Dubiel 2015-08-08 23:50:04 UTC

On emerging gitg there appearer compilation error from vala compiler. Probably this error should be pass to gitg upstream for fixing file generation on build configuration.

 

Reproducible: Always

Steps to Reproduce:
1. Have only net-libs/webkit-gtk-2.8.3
2. emerge =dev-vcs/gitg-3.16.1
Actual Results:  
Could not find GIR file 'WebKit2-3.0.gir'; check XDG_DATA_DIRS or use --includedir
error parsing file Gitg-1.0.gir: Failed to parse included gir WebKit2-3.0
Makefile:5662: recipe for target 'Gitg-1.0.typelib' failed
make[2]: *** [Gitg-1.0.typelib] Error 1


Expected Results:  
emerge pass smoothly 

It could be fixed setting proper version for WebKit2 in gitg gir file. Simple sed fixed the problems.

sed -e 's/name="WebKit2" version="3.0"/name="WebKit2" version="4.0"/g' -i Gitg-1.0.gir

Comment 1 Alexandre Rostovtsev (RETIRED) gentoo-dev

2015-08-20 06:23:07 UTC

Please attach your complete build log and config.log

The error you described in theory shouldn't happen unless you e.g. tried to install/uninstall webkit-2.8 and 2.6 while gitg is compiling.

Comment 2 Alexandre Rostovtsev (RETIRED) gentoo-dev

2015-08-20 06:27:58 UTC

(In reply to Alexandre Rostovtsev from comment #1)
> webkit-2.8 and 2.6

webkit-gtk-2.8 and 2.6

Comment 3 Łukasz Dubiel 2015-08-28 00:28:04 UTC

Created attachment 410492 [details]
build-log

Error still exist. In attachment log from emerge gitg today without any others compilation.

I thing there is problem around dependency discovery on build.
Builds try to build with Webkit2-3 but in system vala there is only Webkit2-4.

Comment 4 Mike Auty (RETIRED) gentoo-dev

2015-08-29 17:20:45 UTC

This is a known upstream bug [1], which they've fixed in the unstable version.

My attempts to backport the patch [2], haven't been successful (it seems to build the gir files in the wrong order), and I don't know enough about fixing autotools to get the gir files built in the correct order.  I've therefore just patched the prebuilt Gir file for this version.

[1] https://bugzilla.gnome.org/show_bug.cgi?id=735299
[2] https://git.gnome.org/browse/gitg/commit/?id=58e2d6e2b544f6a6a9e775faae2cc4b282e27c4c

Comment 5 Łukasz Dubiel 2015-09-03 17:42:47 UTC

Thanks