| Summary: | net-p2p/classified-ads-0.07_p1 version bump | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Antti Järvinen <antti.jarvinen> |
| Component: | New packages | Assignee: | Antti Järvinen <antti.jarvinen> |
| Status: | RESOLVED TEST-REQUEST | ||
| Severity: | normal | CC: | idella4, proxy-maint |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://katiska.org/classified_ads/ | ||
| See Also: | https://bugs.gentoo.org/show_bug.cgi?id=555560 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 555560 | ||
| Attachments: |
diff -u between previous version and the updated version
Updated ebuild Ebuild diff -u between 0.07 and proposed 0.07_p20150728 Updated ebuild Ebuild diff -u between 0.07 and proposed 0.07_p20150728 Updated ebuild Ebuild diff -u between 0.07 and proposed 0.07_p20150728 Updated ebuild |
||
|
Description
Antti Järvinen
2015-07-23 20:55:56 UTC
Created attachment 407478 [details, diff]
diff -u between previous version and the updated version
Created attachment 407480 [details]
Updated ebuild
1) Please use _pYYYYMMDD while YYYYMMDD is dated to the last commit that is included in your version 2) Use COMMIT_ID as a variable to store the commit hash and use this in SRC_URI 3) You might want to use vcs-snapshot.eclass to avoid fiddling with $S. 4) Please replace make with emake in src_test. Created attachment 407952 [details, diff] Ebuild diff -u between 0.07 and proposed 0.07_p20150728 Hello Manuel, thank you for you comments. Please find attached diff that has following modifications > 1) Please use _pYYYYMMDD while YYYYMMDD is dated > to the last commit that is included in your version Ok. > 2) Use COMMIT_ID as a variable to store the commit hash > and use this in SRC_URI Ok. > 3) You might want to use vcs-snapshot.eclass to avoid fiddling with $S. Ok. > 4) Please replace make with emake in src_test. Ok, test-cases are all passing ;what is the difference btw between emake and make, they seem to behave in similar manner.. Created attachment 407954 [details]
Updated ebuild
> > 4) Please replace make with emake in src_test.
>
> Ok, test-cases are all passing ;what is the difference btw
> between emake and make, they seem to behave in similar manner..
emake is a wrapper around make and respect settings in make.conf like MAKE_OPTS.
It also calls "|| die" internally if something goes wrong.
You can simplify the ebuild if RDEPEND is a subset of DEPEND by setting RDEPEND first and then add DEPEND="${RDEPEND} otherdeps"
If both only share a small set but don't overlap completely, you can also use another variable (usually CDEPEND (C for common)) and add RDEPEND="${CDEPEND} otherdeps" DEPEND="${CDEPEND} otherdeps2"
Created attachment 408018 [details, diff]
Ebuild diff -u between 0.07 and proposed 0.07_p20150728
All right, that RDEPEND-suggestion was actually a good one, please find attached ebuild (diff) implementing the change.
Created attachment 408020 [details]
Updated ebuild
By convention, .tar.gz\ and raw=true\ should be
.tar.gz \ and raw=true \ .
SRC_URI="https://github.com/operatornormal/classified-ads/archive/${COMMIT_ID}.tar.gz\
-> ${P}.tar.gz \
I would tend to put on one line considering it is already reduced, both work.
The 2nd is so long I'd leave it split.
The _pYYYYMMDD is the convention syntax for post release snapshots. Personally I'd locate the COMMIT_ID the line prior to DESCRIPTION, again convention.
Note:
RDEPEND="dev-libs/openssl:0
dev-libs/qjson
then
test? ( dev-libs/libgcrypt:0
dev-qt/qttest:4
By convention, additions after the first dep are indented with 2 tab spaces, as in the test? ( ). See you did it with if use doc. It's style but you may as well set that with the others.
Seeing mrueg has more time now and gave you most tips, let's let you make those minor edits
By convention, .tar.gz\ and raw=true\ should be
.tar.gz \ and raw=true \ .
SRC_URI="https://github.com/operatornormal/classified-ads/archive/${COMMIT_ID}.tar.gz\
-> ${P}.tar.gz \
I would tend to put on one line considering it is already reduced, both work.
The 2nd is so long I'd leave it split.
The _pYYYYMMDD is the convention syntax for post release snapshots. Personally I'd locate the COMMIT_ID the line prior to DESCRIPTION, again convention.
Note:
RDEPEND="dev-libs/openssl:0
dev-libs/qjson
then
test? ( dev-libs/libgcrypt:0
dev-qt/qttest:4
By convention, additions after the first dep are indented with 2 tab spaces, as in the test? ( ). See you did it with if use doc. It's style but you may as well set that with the others.
Seeing mrueg has more time now and gave you most tips, let's let you make those minor edits
Created attachment 408074 [details, diff] Ebuild diff -u between 0.07 and proposed 0.07_p20150728 > By convention, .tar.gz\ and raw=true\ should be > .tar.gz \ and raw=true \ . > > SRC_URI="https://github.com/operatornormal/classified-ads/archive/${COMMIT_ID}.tar.gz\ > -> ${P}.tar.gz \ > > I would tend to put on one line considering it is already reduced, both work. > The 2nd is so long I'd leave it split. The first source is now in one line. Is it btw normal that while fetching it first tries to download from distfiles.gentoo.org and resort to github URL only after having received 404 from distfiles.g.o? > Personally I'd locate the COMMIT_ID the line prior to DESCRIPTION, > again convention. Order now changed. > By convention, additions after the first dep are indented with 2 > tab spaces, as in the test? ( ). See you did it with if use doc. > It's style but you may as well set that with the others. Indentation is now 2 tabs for all deps. Created attachment 408076 [details]
Updated ebuild
I have edited the syntax amd order of deps slightly to certain norms. It's too fiddly to explain here, wait until irc. The content is right and the ebuild 'works' so it's merely 'form addressed here. *classified-ads-0.07_p20150728 (01 Aug 2015) 01 Aug 2015; Ian Delaney <idella4@gentoo.org> +classified-ads-0.07_p20150728.ebuild: bump; a snapshot of a post release to address a version update of library miniupnpc wrt bugs #555724 & #555560. SRC_URI adjusted accordingly, also improvements to syntax and style |
