Bug 555060 – app-vim/colorschemes-20140623-r1 breaks under compatibility mode

• Product: Gentoo Linux
• Status: CONFIRMED ---

[Description Kent Fredric (IRC: kent\n) (RETIRED) 2015-07-16 09:09:19 UTC]

Created attachment 406908 [details, diff]
briofita-support-3.1.0-nocp.patch

How to replicate the issue:

1. Install app-vim/colorschemes
2. vim -u NORC 

Error detected while processing /usr/share/vim/vimfiles/plugin/briofita-support.vim:
line  127:
E723: Missing end of Dictionary '}':
E15: Invalid expression: { "statusline":         "StatusLine",
line  128:
E10: \ should be followed by /, ? or &
line  129:
E10: \ should be followed by /, ? or &
line  130:
E10: \ should be followed by /, ? or &
line  131:
E10: \ should be followed by /, ? or &
line  132:
E10: \ should be followed by /, ? or &
line  133:
E10: \ should be followed by /, ? or &
line  134:
E10: \ should be followed by /, ? or &
line  135:
E10: \ should be followed by /, ? or &
line  136:
E10: \ should be followed by /, ? or &
line  137:
E10: \ should be followed by /, ? or &
line  138:
E10: \ should be followed by /, ? or &
line  139:
E10: \ should be followed by /, ? or &

E10 is of course: http://vimhelp.appspot.com/message.txt.html#E10 

"Yay, line continuations not supported".

Attached patch avoids this problem by locally turning on line continuation support within the plugin, and returning the users preferred setting after loading.

Same patch has been sent upstream.

[Comment 1 Patrice Clement (RETIRED) 2017-07-27 15:32:52 UTC]

Kent, do you think you could fix this bug yourself now? :)

[Comment 2 Kent Fredric (IRC: kent\n) (RETIRED) 2017-07-29 10:34:07 UTC]

The affected code comes a 3rd party, "brofita" which upstream has released fixes for:

http://www.vim.org/scripts/script.php?script_id=4136

https://github.com/sonobre/briofita_vim/blob/master/ChangeLog#changelog-briofita-vim-colorscheme

However, the package we see in portage is a bit confusing, because there *is* no upstream-apparent, all things consuming vim-plugins.eclass defaults to fetching from here:

http://dev.gentoo.org/~radhermit/vim/

So its not clear what the upstream is for colorschemes.

The metadata is *terrible*.

[I] app-vim/colorschemes
     Available versions:  20140623-r1
     Installed versions:  20140623-r1(05:28:34 06/09/15)
     Homepage:            http://www.vim.org/
     Description:         vim plugin: a collection of color schemes from vim.org


Fortunately, analysis indicates this is the only package that is confusing like this, and must be a gentoo-authored aggregation of packages.

So I guess somebody just needs to refresh the bundle sometime this side of the decade.

However, upstream has changed a bit from last time: 

qlist colorschemes  | grep -i brio
/usr/share/vim/vimfiles/colors/briofita.vim
/usr/share/vim/vimfiles/doc/briofita.txt
/usr/share/vim/vimfiles/plugin/briofita-support.vim


There's no longer a plugin in the new version called that, and it seems the newer version is more "self contained"

Old version: https://github.com/vim-scripts/Briofita
New version: https://github.com/sonobre/briofita_vim