Bug 554956 – dev-perl/Perl-Tags-0.280.0-r1 tests run indefinitely

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Kent Fredric (IRC: kent\n) (RETIRED) 2015-07-15 12:06:53 UTC]

This is almost the same as my similar bug #523722

However, the symptom is different.

A vim file has an error in it, and this causes the test to block indefinitely:

>>> Test phase: dev-perl/Perl-Tags-0.280.0-r1
make -j10 --load-average=2 test TEST_VERBOSE=0 
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/00-load.t t/01_basic.t t/02_subclass.t t/03_exuberant.t t/04_ppi.t t/05_vim.t t/boilerplate.t t/pod.t
t/00-load.t ....... 1/1 # Testing Perl::Tags 0.28, Perl 5.022000, /usr/bin/perl
t/00-load.t ....... ok   
t/01_basic.t ...... ok   
t/02_subclass.t ... ok     
t/03_exuberant.t .. ok   
t/04_ppi.t ........ ok   
t/05_vim.t ........ Vim: Warning: Output is not to a terminal
Vim: Warning: Input is not from a terminal
Error detected while processing /usr/share/vim/vimfiles/plugin/briofita-support.vim:
line  127:
E723: Missing end of Dictionary '}': 
E15: Invalid expression: { "statusline":         "StatusLine",
line  128:
E10: \ should be followed by /, ? or &
line  129:
E10: \ should be followed by /, ? or &
line  130:
E10: \ should be followed by /, ? or &
line  131:
E10: \ should be followed by /, ? or &
line  132:
E10: \ should be followed by /, ? or &
line  133:
E10: \ should be followed by /, ? or &
line  134:
E10: \ should be followed by /, ? or &
line  135:
E10: \ should be followed by /, ? or &
line  136:
E10: \ should be followed by /, ? or &
line  137:
E10: \ should be followed by /, ? or &
line  138:
E10: \ should be followed by /, ? or &
line  139:
E10: \ should be followed by /, ? or &No protocol specified

Press ENTER or type command to continue



I would propose this test gets PERL_RM_FILES=() treatment as its so prone to vim conditions contaminating and breaking it needlessly.

[Comment 1 Patrice Clement (RETIRED) 2015-07-16 07:44:54 UTC]

I can't reproduce the error.

>>> Test phase: dev-perl/Perl-Tags-0.280.0-r1
make -j2 test TEST_VERBOSE=0
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'inc', 'b
lib/lib', 'blib/arch')" t/00-load.t t/01_basic.t t/02_subclass.t t/03_exuberant.t t/04_ppi.t t/05_vim.t t/boilerplate.t t/pod.t
t/00-load.t ....... 1/1 # Testing Perl::Tags 0.28, Perl 5.020002, /usr/bin/perl
t/00-load.t ....... ok
t/01_basic.t ...... ok
t/02_subclass.t ... ok
t/03_exuberant.t .. ok
t/04_ppi.t ........ ok
t/05_vim.t ........ ok
t/boilerplate.t ... ok
t/pod.t ........... ok
All tests successful.
Files=8, Tests=48,  1 wallclock secs ( 0.07 usr  0.02 sys +  0.64 cusr  0.10 csys =  0.83 CPU)
Result: PASS
>>> Completed testing dev-perl/Perl-Tags-0.280.0-r1

[Comment 2 Kent Fredric (IRC: kent\n) (RETIRED) 2015-07-16 07:58:37 UTC]

You first need a vim that is broken with a trivial replacement vimrc

  echo > _vimrc
  vim -u _vimrc




vim -u _vimrc
Error detected while processing /usr/share/vim/vimfiles/plugin/briofita-support.vim:
line  127:
E723: Missing end of Dictionary '}': 
E15: Invalid expression: { "statusline":         "StatusLine",
line  128:
E10: \ should be followed by /, ? or &
line  129:
E10: \ should be followed by /, ? or &
line  130:
E10: \ should be followed by /, ? or &
line  131:
E10: \ should be followed by /, ? or &
line  132:
E10: \ should be followed by /, ? or &
line  133:
E10: \ should be followed by /, ? or &
line  134:
E10: \ should be followed by /, ? or &
line  135:
E10: \ should be followed by /, ? or &
line  136:
E10: \ should be followed by /, ? or &
line  137:
E10: \ should be followed by /, ? or &
line  138:
E10: \ should be followed by /, ? or &
line  139:
E10: \ should be followed by /, ? or &
Press ENTER or type command to continue


without the custom vimrc, vim works fine.

The file in question that trips comes from app-vim/colorschemes

*why* it fails I don't know, but it is immaterial: I have vim spew these errors for time to time, because
vim extensions are incredibly fragile.

As such, this test is overly sensitive to any vim failures, and so this test is more likely to fail falsely due to vim itself being broken by the vimrc override.

== This test should be testing itself. But instead, its testing vim works with an empty vimrc file.

[Comment 3 Patrice Clement (RETIRED) 2015-07-17 08:44:26 UTC]

I've recompiled vim with Perl support and compiled this package again. This test passes fine. However, I run into another (similar) problem: upon completion, my terminal is completely garbled and unusable.

Let's do away with this test.

+*Perl-Tags-0.280.0-r2 (17 Jul 2015)
+
+  17 Jul 2015; Patrice Clement <[e-mail]>
+  +Perl-Tags-0.280.0-r2.ebuild:
+  Remove a broken test. Fix bug 554956.
+

Thanks Kent.

[Comment 4 Kent Fredric (IRC: kent\n) (RETIRED) 2015-07-17 08:45:21 UTC]

Oh, fwiw, I also sent this bug upstream and hope they can make the test less sensitive in future.

https://rt.cpan.org/Ticket/Display.html?id=105899

Just the fragility of vim means the test is not great still.