Summary: | dev-lang/php[fpm oci8] should add env[ORACLE_HOME] line to php-fpm.conf | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Zoltán Halassy <zhalassy> |
Component: | Current packages | Assignee: | PHP Bugs <php-bugs> |
Status: | RESOLVED NEEDINFO | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | AMD64 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Zoltán Halassy
2015-06-12 13:50:20 UTC
I am not sure about this. How would we ensure VERSION is correct and such? We could add einfo about setting this in postinst, but generally, I think this is just something end users need to configure. An einfo should be good enough. But the ebuild also could read the /etc/env.d/50oracle-instantclient-basic file. Like: ORACLE_HOME=`grep ^ORACLE_HOME= /etc/env.d/50oracle-instantclient-basic | cut -d= -f2` (In reply to Zoltán Halassy from comment #2) > An einfo should be good enough. But the ebuild also could read the > /etc/env.d/50oracle-instantclient-basic file. Like: > > ORACLE_HOME=`grep ^ORACLE_HOME= /etc/env.d/50oracle-instantclient-basic | > cut -d= -f2` Then I'd rather just disable clear_env: http://php.net/manual/en/install.fpm.configuration.php#clear-env Well, if it's considered secure enough, then the provided default config file could explicitly set clear-env to false. Or if not, then an einfo could warn about it still. Try setting, env[ORACLE_HOME] = $ORACLE_HOME That will pull the value of $ORACLE_HOME from the environment, but I'm not sure if $ORACLE_HOME will have the correct value by the time that php-fpm starts. If it does work, I'll add that line to php-fpm.conf in a new revision. Ping... we need an Oracle user to test the trick in comment #5. I'm certain that setting "env[ORACLE_HOME] = $ORACLE_HOME" in php-fpm.conf pulls in the value of $ORACLE_HOME from the environment, but I'm not sure at what point during your boot sequence the $ORACLE_HOME environment variable gets set. It would need to be before php-fpm starts. I'm going to mark this NEEDINFO for now, but feel free to reopen it if you're able to test the idea in comment #5. |