Bug 551834 – net-wireless/broadcom-sta wl driver is not compatible with CONFIG_X86_INTEL_LPSS=y

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Thomas Haschka 2015-06-11 21:28:47 UTC]

The following error occurs loading the wl module when the CONFIG_X86_INTEL_LPSS flag is enabled. ( dmesg output )
[   14.719376] wl: module license 'Mixed/Proprietary' taints kernel.
[   14.719382] Disabling lock debugging due to kernel taint
[   14.727485] ioremap: invalid physical address 1100001000

the difference between a kernel that can use the provided module and can't can be tracked down to the following:

265a266
> CONFIG_HAVE_CLK=y
377,378c378,380
< # CONFIG_X86_INTEL_LPSS is not set
< # CONFIG_IOSF_MBI is not set
---
> CONFIG_X86_INTEL_LPSS=y
> CONFIG_IOSF_MBI=y
> # CONFIG_IOSF_MBI_DEBUG is not set
544a547
> CONFIG_PM_CLK=y
1466a1470
> # CONFIG_KEYBOARD_SAMSUNG is not set
1713a1718
> CONFIG_I2C_DESIGNWARE_PLATFORM=y
1765a1771,1776
> CONFIG_PINCTRL=y
> 
> #
> # Pin controllers
> #
> # CONFIG_DEBUG_PINCTRL is not set
1928a1940
> # CONFIG_INTEL_SOC_DTS_THERMAL is not set
2594a2607,2608
> CONFIG_MMC_SDHCI_PXAV3=m
> CONFIG_MMC_SDHCI_PXAV2=m
2928a2943,2951
> CONFIG_CLKDEV_LOOKUP=y
> CONFIG_HAVE_CLK_PREPARE=y
> CONFIG_COMMON_CLK=y
> 
> #
> # Common Clock Framework
> #
> # CONFIG_COMMON_CLK_SI5351 is not set
> # CONFIG_COMMON_CLK_PXA is not set

As several invalid flags are looked up in the ebuild this conflict should probably be added (if reproducable on an other machine.) I don't have an other one with INTEL_LPSS and a broadcom chip, hence I can't test this. 

I further would report this to upstream if someone can hint me where. 

Reproducible: Always

Steps to Reproduce:
1. compile and run a kernel with CONFIG_X86_INTEL_LPSS=y
2. emerge broadcom-sta 

Actual Results:  
the wl kernel module loads but reports a failed ioremap error in dmesg. The wireless interface does not show up. 

Expected Results:  
the ebuild should throw a warning trying to emerge the driver with CONFIG_X86_INTEL_LPSS=y in the current config

Ultimatly the driver should work with the flaig enabled but this should be reported to upstream.

[Comment 1 Thomas Haschka 2015-06-11 21:29:45 UTC]

Created attachment 404994 [details]
lspci -vvk

[Comment 2 Thomas Haschka 2015-06-11 21:30:11 UTC]

Created attachment 404996 [details]
emerge --info

[Comment 3 Thomas Haschka 2015-06-20 00:31:25 UTC]

This is resolved by activating lpss/baytrail options available in 
linux-4.0.5-gentoo.

[Comment 4 Mike Pagano 2015-06-20 17:49:23 UTC]

Would you mind documenting in this bug the config options that fixed this?

[Comment 5 Thomas Haschka 2015-06-20 20:51:57 UTC]

I will do my best. I don't really know if updating to linux-4.0.5-gentoo from 3.18.12 or setting some options during the upgrade fixed it ( during make oldconfig ).. 

It looks as if in 4.0.5 the support for this platform has vastly improved as also the eMMC is detected way faster and doesn't throw errors anymore at boot. This is an Intel Celeron N2840 (SoC Baytrail) - HP Stream X360

In 3.18.12 i had to deactivate CONFIG_X86_INTEL_LPSS in order to get wifi (broadcom-sta with BCM43142) working. Which in this case doesn't allow you to use the sideband CONFIG_IOSF_MBI and hence the internal disk, i2c, touchscreen etc were not enabled. The system actually runs of an 128G sd card in the slot, which is on purpose.

I will send you all three kernel configuration. 
config-bcm-wifi   - The 3.18.12 config which allowed me to use wifi
config-intel-lpss - The 3.18.12 config which allowed me to use other components on this platform such as the internal eMMC card, touchscreen etc
config-4.0.2      - The 4.0.5 config that allows me to use both intel-lpss and wifi with broadcom-sta

[Comment 6 Thomas Haschka 2015-06-20 20:53:51 UTC]

Created attachment 405436 [details]
Kernel config (3.18.2) without intel lpss that allows you to use broadcom-sta

[Comment 7 Thomas Haschka 2015-06-20 20:55:01 UTC]

Created attachment 405438 [details]
Kernel config (3.18.2) with intel lpss that triggers this bug

[Comment 8 Thomas Haschka 2015-06-20 20:56:39 UTC]

Created attachment 405440 [details]
Kernel config (4.0.5) that allows you to use the broadcom driver while using lpss

[Comment 9 Matt Turner 2017-09-09 20:37:45 UTC]

Dropping myself as a maintainer.

If you are stuck using this unmaintained driver (likely in a MacBook),
you may be interested to know that a newer compatible wireless card
is supported by the in-tree brcmfmac driver. It has a model number 
BCM943602CS and is for sale on the second hand market for less than 
20 USD.

See https://wikidevi.com/wiki/Broadcom_Wireless_Adapters and
    https://wikidevi.com/wiki/Broadcom_BCM943602CS
for more information.

[Comment 10 Pacho Ramos 2018-03-13 16:30:26 UTC]

Nick mailed me showing interest on fixing and maintaining this. Probably the way to do (until you become a developer) would be to maintain it via proxy-maint and send a PR fixing the existing bugs
https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers

[Comment 11 Larry the Git Cow 2018-03-25 22:07:56 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5aea9546fc3c8b521cb272e0c8b996c7388b0b17

commit 5aea9546fc3c8b521cb272e0c8b996c7388b0b17
Author:     Nick Sarnie <[e-mail]>
AuthorDate: 2018-03-13 19:38:15 +0000
Commit:     Gilles Dartiguelongue <[e-mail]>
CommitDate: 2018-03-25 22:07:43 +0000

    net-wireless/broadcom-sta: Warn the user about CONFIG_X86_INTEL_LPSS
    
    Bug: https://bugs.gentoo.org/551834
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 net-wireless/broadcom-sta/broadcom-sta-6.30.223.271-r4.ebuild | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)}