Bug 551700

Summary:	enable doc use flag in dev-java/jdom:2
Product:	Gentoo Linux	Reporter:	William L. Thomson Jr. <wlt-ml>
Component:	[OLD] Java	Assignee:	Java team <java>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	test classes in jar

Description William L. Thomson Jr. 2015-06-10 19:25:01 UTC

jdom-2.0.6.ebuild presently has documentation disabled per changes to eclass, ejavadoc. Which was committed in April. Just need to uncomment code in the ebuild and bump the revision, as the current version is stable. Might then need to file a stable request, or wait 30 days with uncommented doc use flag. Though not sure that should effect stabilization. I don't think the code can be uncommented in the current stable ebuild. Its changing what is installed and use flags, so should require a revision bump.

Comment 1 Patrice Clement gentoo-dev

2015-08-25 22:12:45 UTC

commit 762e1d6 (HEAD, origin/master, origin/HEAD, master)
Author: Patrice Clement <monsieurp@gentoo.org>
Date:   Tue Aug 25 23:11:42 2015 +0000

    dev-java/jdom: Do away with the hacks and rewrite this ebuild from scratch using java-pkg-simple. Doing so, this eclass is now generating the documentation for free. Fixes 551700.
    
    Package-Manager: portage-2.2.18
    Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

 create mode 100644 dev-java/jdom/jdom-2.0.6-r1.ebuild

Comment 2 William L. Thomson Jr. 2015-08-25 22:51:27 UTC

The modified version needs to be removed. If you insist on using java-pkg-simple which is fine to use, you need to remove the tests. Also junit should only be a dep if the test USE flag is set. Same thing with compiling tests. The modifications are not including tests in the resulting jar file and junit is now a dep all the time, regardless of test USE flag. That is NOT correct! See the attached result of the modifications. There should only be 318 files, but instead there are 629 because of all the tests not being included.

Comment 3 William L. Thomson Jr. 2015-08-25 22:52:43 UTC

Created attachment 410294 [details]
test classes in jar

Comment 4 Patrice Clement gentoo-dev

2015-08-26 08:18:17 UTC

commit e767910 (HEAD, master)
Author: Patrice Clement <monsieurp@gentoo.org>
Date:   Wed Aug 26 09:16:21 2015 +0000

    dev-java/jdom: Tests are not unconditional anymore. Fixes bug 551700.

    Package-Manager: portage-2.2.18
    Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

 create mode 100644 dev-java/jdom/jdom-2.0.6-r2.ebuild

There you go, big boy.

"A patch is worth more than a thousand words". ;)