| Summary: | x11-apps/xconsole-1.0.6 : /.../xconsole.c:795:6: error: implicit declaration of function ‘openpty’ [-Werror=implicit-function-declaration] | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Thomas Haschka <raketenzwerg83> |
| Component: | Current packages | Assignee: | Matt Turner <mattst88> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | x11, ysottre |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 416069 | ||
| Bug Blocks: | |||
| Attachments: |
build.log
xconsole-1.0.6-r1.ebuild xconsole-1.0.6-update-configure.ac.patch xconsole-1.0.6-r1.ebuild #2 |
||
Please attach the build log. Created attachment 404698 [details]
build.log
Something is going wrong in src_configure(). Compare his failed build: >checking for library containing openpty... -lutil >checking for openpty... yes >checking util.h usability... yes >checking util.h presence... yes >checking for util.h... yes >checking that generated files are newer than configure... done >configure: creating ./config.status With my successful build: >checking for library containing openpty... -lutil >checking for openpty... yes >checking util.h usability... no >checking util.h presence... no >checking for util.h... no >checking libutil.h usability... no >checking libutil.h presence... no >checking for libutil.h... no >checking pty.h usability... yes >checking pty.h presence... yes >checking for pty.h... yes >checking that generated files are newer than configure... done >configure: creating ./config.status Created attachment 404726 [details] xconsole-1.0.6-r1.ebuild Quick fix is to force it to use openpty from pty.h. @Thomas Haschka, can you please test this ebuild in a local overlay. See https://wiki.gentoo.org/wiki/Overlay/Local_overlay for instructions on setting one up. @Andrew Miller Your ebuild works for me! Thanks! (In reply to Thomas Haschka from comment #5) That's good news, but like I said it's a quick fix, not something we can put in the tree. A more robust fix is to add some logic to the configure script so it defaults to pty.h, and only tries to include util.h on mac/nbsd/obsd and libutil.h on fbsd. Created attachment 404756 [details, diff]
xconsole-1.0.6-update-configure.ac.patch
Created attachment 404758 [details]
xconsole-1.0.6-r1.ebuild #2
Please test this ebuild too.
(In reply to Andrew Miller from comment #8) > Created attachment 404758 [details] > xconsole-1.0.6-r1.ebuild #2 > > Please test this ebuild too. Works perfectly with the patch ! (In reply to Andrew Miller from comment #3) > Something is going wrong in src_configure(). Compare his failed build: I can confirm. My build looks like Andrew Miller's successful build. Thomas, are you still able to reproduce this? If so, could you check out the upstream sources and try those? $ git clone git://anongit.freedesktop.org/xorg/app/xconsole $ cd xconsole $ ./autogen.sh $ make If that succeeds, please run $ git clean -dxf $ git checkout HEAD~ $ ./autogen.sh $ make and report whether that works. I'm speculating that the top of the tree -- commit 649966c9f22e8 ("config: add AC_USE_SYSTEM_EXTENSIONS") at the time of this writing -- fixes the build for you. The attached patch does a superset of that, all of which I don't believe is necessary. I've made a 1.0.7 release and pushed it into Gentoo. |
x11-apps/xconsole-1.0.6 fails to build. This prevents xdm from working the error is "implicit declaration of 'openpty'" c.f. build log. This happens on all my machines Reproducible: Always Steps to Reproduce: 1. emerge -upv x11-apps/xconsole-1.0.6 Actual Results: build fails with the error /var/tmp/portage/x11-apps/xconsole-1.0.6/work/xconsole-1.0.6/xconsole.c:795:2: error: implicit declaration of function ‘openpty’ [-Werror=implicit-function-declaration] if (openpty(pty, tty, NULL, NULL, NULL) == -1) { ^ Expected Results: build should succeed and install haschka@sputnik ~ $ emerge --info Portage 2.2.18 (python 2.7.9-final-0, default/linux/amd64/13.0/no-multilib, gcc-4.8.4, glibc-2.20-r2, 3.18.12-gentoo x86_64) ================================================================= System uname: Linux-3.18.12-gentoo-x86_64-Intel-R-_Celeron-R-_CPU_N2840_@_2.16GHz-with-gentoo-2.2 KiB Mem: 1934512 total, 1393440 free KiB Swap: 1048568 total, 1048568 free Timestamp of repository gentoo: Sat, 06 Jun 2015 16:30:01 +0000 sh bash 4.3_p33-r2 ld GNU ld (Gentoo 2.24 p1.4) 2.24 app-shells/bash: 4.3_p33-r2::gentoo dev-lang/perl: 5.20.2::gentoo dev-lang/python: 2.7.9-r1::gentoo, 3.3.5-r1::gentoo, 3.4.1::gentoo dev-util/cmake: 2.8.12.2-r1::gentoo dev-util/pkgconfig: 0.28-r2::gentoo sys-apps/baselayout: 2.2::gentoo sys-apps/openrc: 0.13.11::gentoo sys-apps/sandbox: 2.6-r1::gentoo sys-devel/autoconf: 2.13::gentoo, 2.69::gentoo sys-devel/automake: 1.9.6-r4::gentoo, 1.11.6-r1::gentoo, 1.13.4::gentoo, 1.14.1::gentoo sys-devel/binutils: 2.24-r3::gentoo sys-devel/gcc: 4.8.4::gentoo sys-devel/gcc-config: 1.7.3::gentoo sys-devel/libtool: 2.4.6::gentoo sys-devel/make: 4.1-r1::gentoo sys-kernel/linux-headers: 3.18::gentoo (virtual/os-headers) sys-libs/glibc: 2.20-r2::gentoo Repositories: gentoo location: /usr/portage sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 ACCEPT_KEYWORDS="amd64" ACCEPT_LICENSE="* -@EULA" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-O2 -pipe -march=native" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-O2 -pipe -march=native" DISTDIR="/usr/portage/distfiles" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://distfiles.gentoo.org" LANG="en_US.utf8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j2" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/var/tmp" USE="X acl alsa amd64 berkdb bzip2 cli cracklib crypt cxx dbus dri fontconfig fortran freetype gdbm gif iconv jpeg lcms mmx mmxext modules ncurses nls nptl opengl openmp pam pcre pdf png readline session sse sse2 sse3 sse4_1 sse4_2 ssl ssse3 svg tcpd threads tiff truetype unicode xft zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 sse3 ssse3 sse4_1 sse4_2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="synaptics mutouch keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en de fr" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON