Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 551176

Summary: games-roguelike/nethack: incorrectly ignores cp return status
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: [OLD] GamesAssignee: Mira Ressel <aranea>
Status: RESOLVED TEST-REQUEST    
Severity: normal CC: proxy-maint
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-06-04 09:22:33 UTC
# preserve STATEDIR/{logfile,record} (previous ebuild rev mistakenly removes it)
    cp "${ROOT}/${STATEDIR}/"{logfile,record} "$T"  # nonfatal

This is just wrong. Check whether the file exists, then call cp, then die if cp fails.
Comment 1 Sven Vermeulen (RETIRED) gentoo-dev 2015-06-09 08:36:22 UTC
Luis sent out the updated ebuild and it's committed to the tree (as -r4).