Bug 551152 (bad-nonfatal) – [TRACKER] Incorrect uses of nonfatal

• Product: Quality Assurance
• Status: CONFIRMED ---

[Description Michał Górny 2015-06-04 08:52:37 UTC]

Ebuilds are full of nonfatal mistakes, so let's start complaining.

Common issues:

1. using nonfatal to ignore faulty ebuild code/laziness -- like 'nonfatal dodoc A B C D',

2. using nonfatal with stuff that calls 'die' (relying on Portage bugs).

[Comment 1 Michał Górny 2015-06-04 09:32:22 UTC]

Just to be clear, the correct way of using nonfatal is to disable implicit 'die' call in built-in helpers (like emake), in order to handle the error manually. For example, to perform some additional cleanup before dying or provide custom error message.

Example:

  src_test() {
    food --pidfile "${T}/food.pid"
    nonfatal emake check
    local ret=${?}
    kill "$(<"${T}"/food.pid)"
    [[ ${ret} == 0 ]] || die "Tests fail, oh my"
  }