Bug 54993

Summary:	Fixed ebuild for gsmlib-1.10
Product:	Gentoo Linux	Reporter:	Zach Bagnall <yem>
Component:	New packages	Assignee:	Gentoo PDA project <pda>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	arj, liquidx
Priority:	High
Version:	unspecified
Hardware:	All
OS:	All
URL:	http://www.pxh.de/fs/gsmlib/
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	gsmlib-1.10-r1.ebuild gsmlib-1.10-include-fix.patch gsmlib-1.10-fd-leak-fix.patch

Description Zach Bagnall 2004-06-24 02:49:10 UTC

Copied from Bug 8303.

Stock gsmlib 1.10 doesn't compile due to a missing #include. It also leaks file
descriptors in certain situations. Patches included for both of these issues.

Currently 1.11_pre030826 is marked as stable. This is incorrect. According to
the author's homepage, 1.10 is still the most recent stable. 1.11_pre breaks some software such as gnome-phone-manager (http://usefulinc.com/software/phonemgr).

Suggest adding this 1.10-r1 ebuild (and patches) as stable and making
1.11_pre030826 unstable again as it should be.

Comment 1 Zach Bagnall 2004-06-24 02:51:40 UTC

Created attachment 34038 [details]
gsmlib-1.10-r1.ebuild

Ebuild for 1.10 with two bugs fixed. This should be the current stable version
- not 1.11_pre as in CVS.

Comment 2 Zach Bagnall 2004-06-24 02:52:52 UTC

Created attachment 34039 [details, diff]
gsmlib-1.10-include-fix.patch

Fix for a missing #include in gsmlib/gsm_unix_serial.cc

Comment 3 Zach Bagnall 2004-06-24 02:54:36 UTC

Created attachment 34040 [details, diff]
gsmlib-1.10-fd-leak-fix.patch

Fix for leaked file descriptors.

Comment 4 Alastair Tse (RETIRED) gentoo-dev

2004-06-25 20:20:37 UTC

no need to cc me. i'm on the pda herd ;)

Comment 5 Anders Rune Jensen (RETIRED) gentoo-dev

2004-06-30 09:06:50 UTC

The latest pre-release is 040603. Like the current snapshot in portage it doesn't compile with gcc-3.4. 1.10 and -r1 has the same problem.

Comment 6 Zach Bagnall 2004-07-01 03:05:27 UTC

Can you attach the gcc 3.4 compiler output here?

Using 3.3.3-r6 (latest stable in portage)..

1.10 doesn't compile due to a missing #include.
1.10-r1 with the #include fixed compiles and works fine.
1.11_pre030826 compiles, but this version breaks some apps that depend on it.

Comment 7 Alastair Tse (RETIRED) gentoo-dev

2004-07-24 13:44:43 UTC

thanks for the patches and comments. i've put this in so that people have options regarding which gsmlib to use. gnome-phone-manager isn't in portage, so i'm not inclined to support it at the moment, but there's an open bug about it.