Bug 549848 – sys-power/pm-utils-1.4.1-r6 logrotate script overrides user-set values

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Dimitrios Semitsoglou-Tsiapos 2015-05-18 20:33:58 UTC]

The logrotate script that ships with pm-utils overrides the following variables which a user may want to set globally in /etc/logrotate.conf:

compress -- Annoying. `zgrep`, for example, does not support `-r`.
rotate 4 -- Dangerous. This dictates when logs are deleted.
monthly  -- Same as above.

A few more points:

* Global configuration is important for predictability and scripting.

* If size on the filesystem is a concern, the user can:
  * set e-mail warnings
  * set filesize-based rotation limits
  * enable compression only for logs which he or she expects to grow

* Logs are a security measure.

Reproducible: Always

[Comment 1 Gilles Dartiguelongue (RETIRED) 2015-05-25 09:44:47 UTC]

This sounds like a good idea but if you are on a quest to fix every logrotate out there, you'd better do a tracking bug and check on gentoo-dev mailing list that this is something we, as a distribution want to achieve as it will involve quite some work with upstream, etc. Such work could be coordinated with other distributions such as debian if it proved to be worthy.

[Comment 2 Larry the Git Cow 2021-02-21 10:57:14 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f146bb7e14ac3405429772d4adfef555f7810c20

commit f146bb7e14ac3405429772d4adfef555f7810c20
Author:     Jakov Smolic <[e-mail]>
AuthorDate: 2021-02-21 10:56:16 +0000
Commit:     David Seifert <[e-mail]>
CommitDate: 2021-02-21 10:56:16 +0000

    sys-power/pm-utils: Remove last-rited pkg
    
    Closes: https://bugs.gentoo.org/659616
    Closes: https://bugs.gentoo.org/703026
    Closes: https://bugs.gentoo.org/666380
    Closes: https://bugs.gentoo.org/579912
    Closes: https://bugs.gentoo.org/549848
    Closes: https://bugs.gentoo.org/533168
    Closes: https://bugs.gentoo.org/489650
    Closes: https://bugs.gentoo.org/443530
    Closes: https://bugs.gentoo.org/442052
    Closes: https://bugs.gentoo.org/437930
    Closes: https://bugs.gentoo.org/426952
    Closes: https://bugs.gentoo.org/426510
    Closes: https://bugs.gentoo.org/403523
    Closes: https://bugs.gentoo.org/401257
    Closes: https://bugs.gentoo.org/362387
    Closes: https://bugs.gentoo.org/257156
    
    Signed-off-by: Jakov Smolic <[e-mail]>
    Signed-off-by: David Seifert <[e-mail]>

 profiles/arch/amd64/package.use.mask               |  4 -
 profiles/arch/base/package.use.mask                |  4 -
 profiles/arch/hppa/use.mask                        |  4 -
 profiles/arch/x86/package.use.mask                 |  4 -
 sys-power/pm-utils/Manifest                        |  1 -
 .../pm-utils/files/1.4.1-bluetooth-sync.patch      | 43 ----------
 .../pm-utils/files/1.4.1-disable-sata-alpm.patch   | 24 ------
 sys-power/pm-utils/files/1.4.1-echo-n.patch        | 51 ------------
 sys-power/pm-utils/files/1.4.1-fix-alpm-typo.patch | 29 -------
 .../1.4.1-fix-intel-audio-powersave-hook.patch     | 40 ---------
 .../pm-utils/files/1.4.1-ignore-led-failure.patch  | 14 ----
 .../files/1.4.1-inhibit-on-right-status.patch      | 20 -----
 .../pm-utils/files/1.4.1-logging-append.patch      | 17 ----
 .../pm-utils/files/1.4.1-run-hook-logging.patch    | 17 ----
 .../pm-utils/files/1.4.1-suspend-hybrid.patch      | 36 ---------
 .../files/1.4.1-uswsusp-hibernate-mode.patch       | 19 -----
 .../files/1.4.1-xfs_buffer_arguments.patch         | 31 -------
 sys-power/pm-utils/files/pm-utils.logrotate        |  8 --
 sys-power/pm-utils/files/power.d/pci_devices       | 61 --------------
 sys-power/pm-utils/files/power.d/usb_bluetooth     | 45 -----------
 sys-power/pm-utils/files/sleep.d/50unload_alx      | 18 -----
 sys-power/pm-utils/metadata.xml                    | 10 ---
 sys-power/pm-utils/pm-utils-1.4.1-r7.ebuild        | 94 ----------------------
 23 files changed, 594 deletions(-)