Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 549506

Summary: sys-fs/lvm2: fails to compile against sys-libs/musl
Product: Gentoo Linux Reporter: Fredric Johansson <fredric.miscmail>
Component: Current packagesAssignee: Gentoo's Team for Core System packages <base-system>
Status: IN_PROGRESS ---    
Severity: normal CC: agk, cardoe, prometheanfire, robbat2
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 430702    
Attachments: Fix stdio usage
fix missing include and pthread constant
Git formatted patch for inclusion in hardened-dev:musl overlay

Description Fredric Johansson 2015-05-14 22:53:49 UTC
lvm2-2.02.110 fails to compile against sys-libs/musl with various errors:
- Bad usage of stdio constants
- missing include to fcntl.h
- missing phtread constant PTHREAD_MUTEX_RECURSIVE_NP

Provided is two patches fixing these issues and one git formatted patch for addition to hardened-dev:musl overlay
Comment 1 Fredric Johansson 2015-05-14 22:55:57 UTC
Created attachment 403278 [details, diff]
Fix stdio usage

Patch fixing usage of stdio constants. Patch is taken from alpine linux (http://git.alpinelinux.org/cgit/aports/tree/main/lvm2/fix-stdio-usage.patch)
Comment 2 Fredric Johansson 2015-05-14 22:56:48 UTC
Created attachment 403280 [details, diff]
fix missing include and pthread constant
Comment 3 Fredric Johansson 2015-05-14 22:58:18 UTC
Created attachment 403282 [details, diff]
Git formatted patch for inclusion in hardened-dev:musl overlay
Comment 4 Anthony Basile gentoo-dev 2015-05-15 22:43:32 UTC
(In reply to Fredric Johansson from comment #3)
> Created attachment 403282 [details, diff] [details, diff]
> Git formatted patch for inclusion in hardened-dev:musl overlay

Committed.  Let's think about getting these patches upstream.
Comment 5 Alasdair Kergon 2015-05-15 23:29:29 UTC
Thanks - we'll take a look at these for upstream.  We've just added quite a bit of new code an another daemon too in today's 2.02.120 release so there could be some new things to deal with.
Comment 6 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2015-08-06 18:58:05 UTC
any more testing done for up-streaming this?