Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 548330

Summary: x11-misc/pcmanfm-1.2.3 ignores the LINGUAS variable set in make.conf
Product: Gentoo Linux Reporter: charles17
Component: Current packagesAssignee: Markos Chandras (RETIRED) <hwoarang>
Status: RESOLVED FIXED    
Severity: normal CC: lxde+disabled
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=547790
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 405485    
Attachments: emerge log
emerge --info x11-misc/pcmanfm
pcmanfm emerge.log
LINGUAS="" emerge -1vt pcmanfm > /tmp/pcmanfm.emerge.log 2>&1
emerge -pqv pcmanfm

Description charles17 2015-05-01 13:34:27 UTC
x11-misc/pcmanfm-1.2.3 ignores the LINGUAS variable set in make.conf

Reproducible: Always

Steps to Reproduce:
1. set LINGUAS="en" in make.conf
2. emerge -1vt =x11-misc/pcmanfm-1.2.3 >> /tmp/pcmanfm.log 2>&1
3.
Actual Results:  
Too many language files installed:
/usr/share/locale/be/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/bg/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/ar/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/ca/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/bn/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/da/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/de/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/cs/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/el/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/fa/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/es/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/fi/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/et/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/eu/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/fo/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/fr/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/gl/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/he/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/id/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/hr/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/hu/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/ja/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/is/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/it/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/kk/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/km/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/ko/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/lg/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/lt/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/lv/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/ms/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/nl/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/pa/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/pl/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/pt/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/ro/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/si/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/ru/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/sk/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/sl/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/te/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/sr/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/th/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/sv/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/tr/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/ug/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/uk/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/vi/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/en_GB/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/pt_BR/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/tt_RU/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/zh_CN/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/zh_TW/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/sr@latin/LC_MESSAGES/pcmanfm.mo

Expected Results:  
It should not install locales I didn't request in my LINGUAS variable.
Comment 1 charles17 2015-05-01 13:35:25 UTC
Created attachment 402388 [details]
emerge log
Comment 2 charles17 2015-05-01 13:40:07 UTC
Created attachment 402390 [details]
emerge --info x11-misc/pcmanfm
Comment 3 Markos Chandras (RETIRED) gentoo-dev 2015-05-17 10:22:17 UTC
--- ChangeLog   2015-05-17 10:34:56.176672957 +0100
+++ ChangeLog.new       2015-05-17 10:35:07.104806207 +0100
@@ -6,6 +6,10 @@
 # Only typo fixes which don't affect portage/repoman behaviour could be avoided
 # here. If in doubt put a record here!
 
+  17 May 2015; Markos Chandras <hwoarang@gentoo.org> desc/linguas.desc:
+  Add tt_RU locale for the Tatar language locale for Russia. It's used by
+  x11-misc/pcmanfm
+

--- ./ChangeLog
+++ ./ChangeLog
@@ -4,0 +5,5 @@
+  17 May 2015; Markos Chandras <hwoarang@gentoo.org> pcmanfm-1.2.3.ebuild,
+  pcmanfm-9999.ebuild:
+  Add l10n eclass support to drop unwanted locales. Add epatch_user. bug
+  #548330. Sync live ebuild as well
+



Should be ok now (at least on my system i get this with LINGUAS="en el en_GB")

~ # qlist pcmanfm|grep locale
/usr/share/locale/el/LC_MESSAGES/pcmanfm.mo
/usr/share/locale/en_GB/LC_MESSAGES/pcmanfm.mo
~ #

Thanks for the report
Comment 4 charles17 2015-05-17 16:20:19 UTC
Created attachment 403496 [details]
pcmanfm emerge.log

(In reply to Markos Chandras from comment #3)
> 
> Should be ok now (at least on my system i get this with LINGUAS="en el
> en_GB")
> 
> ~ # qlist pcmanfm|grep locale
> /usr/share/locale/el/LC_MESSAGES/pcmanfm.mo
> /usr/share/locale/en_GB/LC_MESSAGES/pcmanfm.mo
> ~ #
> 
> Thanks for the report

Not so here. See attached log.
Comment 5 charles17 2015-05-17 16:21:31 UTC
As this one cannot be re-opened, should I file another bug?
Comment 6 Markos Chandras (RETIRED) gentoo-dev 2015-05-17 17:20:04 UTC
I think this is another case of

https://bugs.gentoo.org/show_bug.cgi?id=547790
Comment 7 Markos Chandras (RETIRED) gentoo-dev 2015-05-17 17:30:34 UTC
Should be ok now I hope. It will default to en_GB if nothing is set. Thanks for testing

+  17 May 2015; Markos Chandras <hwoarang@gentoo.org> pcmanfm-1.2.3.ebuild,
+  pcmanfm-9999.ebuild:
+  Set a good default LINGUAS if it's empty. Bug #548330
+
Comment 8 charles17 2015-05-18 05:11:43 UTC
Created attachment 403510 [details]
LINGUAS="" emerge -1vt pcmanfm > /tmp/pcmanfm.emerge.log 2>&1

Still (with v 1.9 2015/05/17 17:30:09) when I do 

LINGUAS="" emerge -1vt pcmanfm > /tmp/pcmanfm.emerge.log 2>&1

it installes all locales.
Comment 9 charles17 2015-05-18 05:12:44 UTC
Created attachment 403512 [details]
emerge -pqv pcmanfm
Comment 10 charles17 2015-05-18 05:19:07 UTC
BTW:
The ebuild says:

DOC_CONTENTS="PCmanFM can optionally support the menu://applications/
        location. You should install lxde-base/lxmenu-data for that
        functionality."

But in fact, the menu reads like "Accessories".
Comment 11 Markos Chandras (RETIRED) gentoo-dev 2015-05-18 20:00:01 UTC
Sorry there was a typo in the ebuild. It should be ok now. As for the message, I will fix it in a later version
Comment 12 charles17 2015-05-19 05:14:08 UTC
(In reply to Markos Chandras from comment #11)
> Sorry there was a typo in the ebuild. It should be ok now. 

Thanks for all your work.  /usr/share/locale gets somewhat cleaner now.