Bug 548316

Summary:	dev-util/diffball-1.0.1 fails to compile with gcc-5.1
Product:	Gentoo Linux	Reporter:	Martin Väth <martin>
Component:	[OLD] GCC Porting	Assignee:	Rafael Martins (RETIRED) <rafaelmartins>
Status:	RESOLVED FIXED
Severity:	normal	CC:	iskatu, rhill
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	536984
Attachments:	build log

Description Martin Väth 2015-05-01 10:39:50 UTC

dev-util/diffball-1.0.1 fails to compile with gcc-5
Probably the most simple fix is to add -std=gnu90 to the CFLAGS

Comment 1 Ryan Hill (RETIRED) gentoo-dev

2015-05-02 23:15:46 UTC

Need a build log.

Comment 2 Martin Väth 2015-05-03 21:07:10 UTC

The linking fails with undefined references of the type

libdiffball/.libs/libdiffball.so: undefined reference to `RHash_cleanse'
(and 5 others)

Which is clear since we have

include/diffball/hash.h:inline signed int RHash_cleanse([...]);
libdiffball/hash.c:RHash_cleanse([...])

Under c90 this is legal, but under newer C dialects, this will inline RHash_cleanse and not export it.

Comment 3 Martin Väth 2015-05-04 09:49:03 UTC

Created attachment 402606 [details]
build log

Comment 4 David Seifert gentoo-dev

2016-04-02 21:49:25 UTC

commit ac593a5e7f2472d3651bdfb6551497449fd9853f
Author: David Seifert <soap@gentoo.org>
Date:   Sat Apr 2 23:48:10 2016 +0200

    dev-util/diffball: add -std=gnu89 to CFLAGS to restore pre-GCC5 semantics
    
    Gentoo-Bug: 548316
    * EAPI=6