Bug 548314

Summary:	app-arch/tarsync-0.2.1-r1 does not compile with gcc-5.1
Product:	Gentoo Linux	Reporter:	Martin Väth <martin>
Component:	[OLD] GCC Porting	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal	CC:	rhill
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	536984
Attachments:	build log

Description Martin Väth 2015-05-01 10:32:34 UTC

app-arch/tarsync-0.2.1-r1 does not compile with gcc-5
Probably the most simple fix is to add -std=gnu90 to the CFLAGS

Comment 1 Ryan Hill (RETIRED) gentoo-dev

2015-05-02 23:15:08 UTC

Need a build log.

Comment 2 Martin Väth 2015-05-03 21:01:40 UTC

The build finishes with linking error: undefined reference to `match_excludes'

Which is clear, since we have:

/tarsync/excludes.h:inline int match_excludes([...]);
./tarsync/excludes.c:match_excludes([...])

In C90, the code is OK, but in newer C dialects, the match_excludes will be inlined and not exported.

Comment 3 Martin Väth 2015-05-04 10:02:44 UTC

Created attachment 402610 [details]
build log

Comment 4 Matthias Maier gentoo-dev

2015-05-26 23:44:18 UTC

I have removed the offending inline keywords such that the symbols get exported.


  26 May 2015; Matthias Maier <tamiko@gentoo.org>
  +files/tarsync-0.2.1-gcc5.patch, tarsync-0.2.1-r1.ebuild:
  fix compilation with gcc-5.1, bug #548314