Bug 547578

Summary:	net-print/hplip-3.15.4 -minimal -fax need not depend on dev-python/dbus-python
Product:	Gentoo Linux	Reporter:	S. Gilles <sgilles>
Component:	Current packages	Assignee:	Daniel Pielmeier <billie>
Status:	RESOLVED FIXED
Severity:	trivial	CC:	printing
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Local patch for ebuild which seems to work fine.

Description S. Gilles 2015-04-24 12:25:50 UTC

The net-print/hplip-3.15.4 ebuild lists dev-python/dbus-python in RDEPEND twice: once under fax? and once directly under !minimal. The dependency under !minimal will always clobber that under fax?, so it seems to make sense to remove one of them. Based on http://hplipopensource.com/hplip-web/install/manual/distros/other.html , fax? is the correct location for the dependency.

For testing, I have removed the line directly under !minimal, ensured I don't have dev-python/dbus-python installed, and standard printing seems to work fine.

Reproducible: Always

Steps to Reproduce:
1. Mask dbus on a bet
2. emerge hplip
Actual Results:  
It should install, even with -minimal

Expected Results:  
The dbus mask prevents dbus-python, preventing hplip.

USE flags for my testing are "hpcups -X -doc -fax -hpijs -kde -libnotify -libusb0 -minimal -parport -policykit -qt4 -scanner -snmp -static-ppds"

Comment 1 S. Gilles 2015-04-24 12:26:55 UTC

Created attachment 401916 [details, diff]
Local patch for ebuild which seems to work fine.

Comment 2 Daniel Pielmeier gentoo-dev

2015-04-26 12:02:19 UTC

(In reply to S. Gilles from comment #0)
> The net-print/hplip-3.15.4 ebuild lists dev-python/dbus-python in RDEPEND
> twice: once under fax? and once directly under !minimal. The dependency
> under !minimal will always clobber that under fax?, so it seems to make
> sense to remove one of them. Based on
> http://hplipopensource.com/hplip-web/install/manual/distros/other.html ,
> fax? is the correct location for the dependency.
> 

+  26 Apr 2015; Daniel Pielmeier <billie@gentoo.org> hplip-3.15.4.ebuild:
+  Remove redundant dependency on dbus-python. This fixes bug #547578. Thanks to
+  S. Gilles for the report.

Do not rely on the information provided at the above link but take a look in the code to check where dbus-python is required. You will find that there are a lot other places besides fax requiring dbus-python. It make sense however to remove it from the fax use flag as this is redundant.