Bug 546742

Summary:	x11-apps/sessreg-1.1.0 fail to build with gcc5
Product:	Gentoo Linux	Reporter:	Cănărău Constantin <canarauc>
Component:	[OLD] GCC Porting	Assignee:	Gentoo X packagers <x11>
Status:	RESOLVED FIXED
Severity:	normal	CC:	b.buschinski, jrmalaq
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.freedesktop.org/show_bug.cgi?id=90615
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	536984
Attachments:	patch to fix issue emerge info emerge -pqv build log environment

Description Cănărău Constantin 2015-04-16 08:43:35 UTC

Missing -P in preprocessor part

Reproducible: Always

Comment 1 Cănărău Constantin 2015-04-16 08:44:09 UTC

Created attachment 401324 [details, diff]
patch to fix issue

Comment 2 Dale Lukas Peterson 2015-04-25 15:36:12 UTC

I'm hitting this issue as well.  See attachments for details.

Comment 3 Dale Lukas Peterson 2015-04-25 15:36:30 UTC

Created attachment 402002 [details]
emerge info

Comment 4 Dale Lukas Peterson 2015-04-25 15:37:20 UTC

Created attachment 402004 [details]
emerge -pqv

Comment 5 Dale Lukas Peterson 2015-04-25 15:37:32 UTC

Created attachment 402006 [details]
build log

Comment 6 Dale Lukas Peterson 2015-04-25 15:37:46 UTC

Created attachment 402008 [details]
environment

Comment 7 Dale Lukas Peterson 2015-04-25 16:47:36 UTC

I placed Cănărău Constantin's patch in /etc/portage/patches/x11-apps/sessreg-1.1.0/sed.patch and it fixes the problem.

Comment 8 Piotr Szymaniak 2015-06-19 20:17:54 UTC

(In reply to Dale Lukas Peterson from comment #5)
> Created attachment 402006 [details]
> build log

Got the same:
/bin/sed: file filenames.sed line 3: unterminated `s' command
Makefile:500: recipe for target 'sessreg.1' failed

Comment 9 Chí-Thanh Christopher Nguyễn gentoo-dev

2015-06-19 21:04:00 UTC

It would be a good idea to submit your fix to the upstream bug.

Comment 10 Bernd Buschinski 2015-07-21 05:59:00 UTC

just for the record,

also fails with gcc-5.2 and patch fixes it.

Comment 11 georg 2015-07-29 17:18:53 UTC

Cănărău Constantin patch did fix the issue for me.

@Cănărău Constantin: Thanks

Comment 12 Tom Li 2015-08-09 09:17:47 UTC

Also confirmed the issue and the patch.

Comment 13 Greg Turner 2015-09-13 21:58:56 UTC

W4M.

As best I can tell, this patch rescues an obscure, ugly approach by making it more obscure and uglier... are we sure it's good karma to send it to upstream?  They have their own bug for it and are discussing solutions that address the underlying problem.

Comment 14 SpanKY gentoo-dev

2015-10-02 13:36:16 UTC

let's leave the debate in upstream for how best to fix this.  in the mean time, added said patch to the tree:
http://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3574435ae3de31bb9409c406154aa03fbbb884f7