| Summary: | USE_EXPAND affects subsequent lines of same atom in package.use | ||
|---|---|---|---|
| Product: | Portage Development | Reporter: | Albert Safin <xzfcpw+gentoo> |
| Component: | Core - Configuration | Assignee: | Portage team <dev-portage> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | xzfcpw+gentoo |
| Priority: | Normal | Keywords: | InVCS |
| Version: | unspecified | ||
| Hardware: | AMD64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 484436 | ||
| Attachments: |
log
Make USE_EXPAND do not affect subsequent lines of same atom in package.use |
||
Created attachment 401194 [details]
log
Created attachment 401272 [details, diff]
Make USE_EXPAND do not affect subsequent lines of same atom in package.use
Patch for latest git version (9b74a79004288572e42140c8084126a4c223fa0d)
Your patch looks pretty reasonable to me. However, when adding new function parameters please use True/False for boolean values rather than integers. The use of integers for boolean values is a style quirk that we should not propagate. Yeah, patch looks good otherwise. Zac, do you want to make an additional patch to change those 0/1 to True/False while we're in here making changes? (In reply to Brian Dolbec from comment #4) > Zac, do you want to make an additional patch to change those 0/1 to > True/False while we're in here making changes? Yeah, maybe later today. I've started a branch here: https://github.com/zmedico/portage/tree/bug_546512 And I've posted the first patch for review here: https://archives.gentoo.org/gentoo-portage-dev/message/44505cbb0d4d10301f511cd1f7a40c90 This is in the master branch: https://gitweb.gentoo.org/proj/portage.git/commit/?id=5c53c0831dc34b7c1edab2ab8726e54cb5957289 Released in portage-2.2.19 |
If you have cat/pkg use1 cat/pkg FOO: use2 cat/pkg use3 in your package.use, portage handles this as cat/pkg use1 foo_use2 foo_use3 , not cat/pkg use1 foo_use2 use3 Reproducible: Always Steps to Reproduce: 1. Replace package.use contents with these two lines: */* ABI_X86: 32 64 */* sqlite3 2. Run `emerge --info` Actual Results: USE does not contains sqlite3, but ABI_X86 does (i.e. ABI_X86="64 32 sqlite3") Expected Results: USE should countain "sqlite3", ABI_X86 should be "64 32"