Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 54580

Summary: libdockapp-0.5.0 breaks backward compatibility
Product: Gentoo Linux Reporter: John Baxter <john>
Component: New packagesAssignee: Michele Noberasco (RETIRED) <s4t4n>
Status: RESOLVED FIXED    
Severity: enhancement CC: s4t4n, troll
Priority: High Keywords: EBUILD
Version: unspecified   
Hardware: x86   
OS: All   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: ebuild that applies the two patches
Adds the DAInitialize function to damain.c
changes #define to void() in dockapp.h

Description John Baxter 2004-06-20 18:14:55 UTC
A change in libdockapp-0.5.0 has broken compatibility. The new library uses a #define for DAInitialize(). Many app's configure scripts test on that function. This ebuild and the two patches change the #define to an actual function call.
Comment 1 John Baxter 2004-06-20 18:16:13 UTC
Created attachment 33718 [details]
ebuild that applies the two patches
Comment 2 John Baxter 2004-06-20 18:17:30 UTC
Created attachment 33719 [details, diff]
Adds the DAInitialize function to damain.c
Comment 3 John Baxter 2004-06-20 18:18:14 UTC
Created attachment 33720 [details, diff]
changes #define to void() in dockapp.h
Comment 4 John Baxter 2004-06-20 18:35:44 UTC
See http://bugs.gentoo.org/show_bug.cgi?id=53605
Comment 5 Przemyslaw Maciag (RETIRED) gentoo-dev 2004-06-23 16:20:46 UTC
100 times : "thank you!".

Regards,
Przemek
Comment 6 Michele Noberasco (RETIRED) gentoo-dev 2004-08-20 14:20:04 UTC
Yet I think 
Comment 7 Michele Noberasco (RETIRED) gentoo-dev 2004-08-20 14:22:31 UTC
Yet I think that if the libdockapp programmers change their library, it's the apps that use it that should be updated, not the library itself...
We should patch the dockapps using libdockapp and send these patches upstream to the developers...
Comment 8 Michele Noberasco (RETIRED) gentoo-dev 2004-08-31 06:13:54 UTC
OK, I'm going to fix the affected packages, not the library itself. Here they are (after some shameless grepping):
x11-plugins/wmacpi
x11-plugins/wmail
x11-plugins/wmcms
x11-plugins/wmdate
x11-plugins/wmlpq
x11-plugins/wmnetload (already fixed)
Comment 9 Michele Noberasco (RETIRED) gentoo-dev 2004-08-31 06:32:06 UTC
OK, wmacpi-1.99 works nicely with libdockapp-0.5.0...
Comment 10 Michele Noberasco (RETIRED) gentoo-dev 2004-08-31 06:58:37 UTC
wmail is also fixed now...
Comment 11 Michele Noberasco (RETIRED) gentoo-dev 2004-08-31 07:03:04 UTC
wmcms works good...
Comment 12 Michele Noberasco (RETIRED) gentoo-dev 2004-08-31 07:07:01 UTC
wmdate too
Comment 13 Michele Noberasco (RETIRED) gentoo-dev 2004-08-31 07:10:09 UTC
wmlpq rocks...
Comment 14 Przemyslaw Maciag (RETIRED) gentoo-dev 2004-08-31 07:12:35 UTC
Hello!

As I remember problemaitcs with libdockapp-0.5.0 are also:
- wsoundserver (I'm pretty sure about that one)
- wmsound (I think....)

Regards,
Przemek
Comment 15 Michele Noberasco (RETIRED) gentoo-dev 2004-08-31 07:52:01 UTC
wsoundserver is not in Portage...
wmsound apparently works OK

So for now I'm closing this...
But feel free to reopen/repost the bug about wsoundserver if you like...

Ah, libdockapp-0.5.0 is now stable in Portage, as are all affected (and now patched) packages that didn't work with it...