Summary: | dev-libs/libindicator-12.10.1-r300 : dev-util/pkgconfig-0.29 outputs no trailing space on --libs, resulting in " -lglib-2.0-lm " to LD | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | Ayatana Bugs <ayatana-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | freedesktop-bugs, kensington |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=562216 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
emerge log
libindicator-12.10.1-r301.build.log |
Description
Toralf Förster
2015-04-02 14:25:10 UTC
Created attachment 413560 [details]
libindicator-12.10.1-r301.build.log
Updating build log
This failure has been introduced by a change in dev-util/pkgconfig-0.29: On my system (mostly stable amd64), with dev-util/pkgconfig-0.28-r2 installed, the space between -lglib-2.0 and -lm is provided by pkg-config, since I can see it explicitly defined in pkg_cv_LIBINDICATOR_LIBS in config.log: config.log:pkg_cv_LIBINDICATOR_LIBS='-lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -Wl,--export-dynamic -lgmodule-2.0 -pthread -lgio-2.0 -lgobject-2.0 -lglib-2.0 ' The results when running ./configure with dev-util/pkgconfig-0.29 however is: config.log:pkg_cv_LIBINDICATOR_LIBS='-lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -Wl,--export-dynamic -lgmodule-2.0 -pthread -lgio-2.0 -lgobject-2.0 -lglib-2.0' As shown, the trailing space is missing. I don't know if this is a pkgconfig bug or a bug in this build system, with the LIBINDICATOR_LIBS+="$LIBM" line in configure.ac not specifying any whitespace. @freedesktop, any idea about which package is at fault? (In reply to Michael Palimaka (kensington) from comment #3) > @freedesktop, any idea about which package is at fault? The configure script, of course. It must add space before additional libs. Also, before you waste your time checking, the upstream bzr still has this bug. Since it's a trivial fix i just did it. Apologies for stepping on anybody's toes. commit 66cb7efcecc1ab67f5b64528ba251805656bcec4 Author: Ian Stakenvicius <axs@gentoo.org> Date: Sun Oct 4 10:15:57 2015 -0400 dev-libs/libindicator: add missing whitespace before -lm When dev-util/pkgconfig-0.29 is in use, the _LIBS output of a PKG_CHECK* does not have a trailing space assigned. This causes the link flags to contain a "-lglib-2.0-lm" assignment as $LIBM was appended to $LIBINDICATOR_LIBS without any whitespace separation. This commit adds the necessary whitespace. Fixes bug 545334 But please report it upstream. We all love launchpad, don't we? (In reply to Michał Górny from comment #7) > But please report it upstream. We all love launchpad, don't we? How're we supposed to do that exactly? :) Quote: https://bugs.launchpad.net/libindicator -- "libindicator must be configured in order for Launchpad to forward bugs to the project's developers. " (In reply to Ian Stakenvicius from comment #8) > (In reply to Michał Górny from comment #7) > > But please report it upstream. We all love launchpad, don't we? > > How're we supposed to do that exactly? :) > > Quote: https://bugs.launchpad.net/libindicator -- "libindicator must be > configured in order for Launchpad to forward bugs to the project's > developers. " Maybe email Ted Gould (listed as the maintainer in http://bazaar.launchpad.net/~indicator-applet-developers/libindicator/trunk.15.10/view/head:/debian/copyright) and CC recent active contributors (e.g. Marco Trevisan and Lars Uebernickel). And tell them to fix their bugs page :) |