Summary: | [kde overlay] dev-util/kdevplatform-9999 fails to compile | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Eugene Shalygin <eugene.shalygin> |
Component: | [OLD] KDE | Assignee: | Gentoo KDE team <kde> |
Status: | RESOLVED TEST-REQUEST | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/kde/issues/190 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
build.log
mark test targets as tests mark kdevelop test targets as tests Adds QTest to headers list |
Description
Eugene Shalygin
2015-03-29 13:06:13 UTC
Created attachment 400020 [details]
build.log
Created attachment 400024 [details, diff]
mark test targets as tests
This patch marks some targets as tests and allows to compile kdevplatform with add_subdirectory(tests) commented out. I think we shall ask upstream why they left these targets as they are.
Created attachment 400030 [details, diff]
mark kdevelop test targets as tests
The very same problems arise in KDevelop if KDevplatform does not install test KDev::Test headers and libraries.
Maybe I miss something, but from browsing the code of the tests subdir I found that those are not self-tests of the package but rather code for tests framework. Therefore it should actually be kept in the code, not removed. I attached a patch to commit 52c34e589dd6fabfe73444b85735191f562cd31a which adds headers for QTest into cmake. Created attachment 401534 [details, diff]
Adds QTest to headers list
Is this still an issue? I changed the eclass in f3331211456dcb58bc4ba8c30d67c29689dddeeb to stop trying to comment out tests outside of frameworks/plasma/apps. |