| Summary: | sys-block/parted: fix includes to enable compiling against musl | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Travis Tilley <ttilley> |
| Component: | Hardened | Assignee: | Gentoo musl team <musl> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | blueness, bugs.gentoo.org |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 430702 | ||
| Attachments: | fix compilation against musl | ||
since this is a really simple patch, and i dont see how this could cause any problems, it should probably land directly in the main tree rather than sit in the overlay IMHO. seriously, the patch is just to add '#include <fnctl.h>' to 'libparted/fs/xfs/platform_defs.h'. Looks fine for upstream. http://lists.alioth.debian.org/mailman/listinfo/parted-devel seems to be the list (unfortunately subscriber only) where to send your patch to. Preferably use git-send-email and say in the message why the include is necessary. Has anyone sent this usptream? http://lists.alioth.debian.org/pipermail/parted-devel/2015-May/004659.html http://lists.alioth.debian.org/pipermail/parted-devel/2015-May/004658.html In upstream git: http://git.savannah.gnu.org/cgit/parted.git/commit/?id=a3877115f1956949096d77aca5a703a47ed68397 Current in tree version works with musl |
Created attachment 399390 [details, diff] fix compilation against musl parted fails to compile against musl's headers. it appears to assume fnctl.h will be pulled in as a side effect of another include. fix attached. i didn't bump the ebuild revision but since this has never compiled against musl before and there isn't an existing ebuild in the musl overlay.