|Summary:||sys-block/parted: fix includes to enable compiling against musl|
|Product:||Gentoo Linux||Reporter:||Travis Tilley <ttilley>|
|Component:||Hardened||Assignee:||Gentoo musl team <musl>|
|Package list:||Runtime testing required:||---|
|Bug Depends on:|
|Attachments:||fix compilation against musl|
Description Travis Tilley 2015-03-21 15:52:45 UTC
Created attachment 399390 [details, diff] fix compilation against musl parted fails to compile against musl's headers. it appears to assume fnctl.h will be pulled in as a side effect of another include. fix attached. i didn't bump the ebuild revision but since this has never compiled against musl before and there isn't an existing ebuild in the musl overlay.
Comment 1 Travis Tilley 2015-03-21 15:53:46 UTC
since this is a really simple patch, and i dont see how this could cause any problems, it should probably land directly in the main tree rather than sit in the overlay IMHO.
Comment 2 Travis Tilley 2015-03-21 15:55:48 UTC
seriously, the patch is just to add '#include <fnctl.h>' to 'libparted/fs/xfs/platform_defs.h'.
Comment 3 Felix Janda 2015-03-21 16:22:23 UTC
Looks fine for upstream. http://lists.alioth.debian.org/mailman/listinfo/parted-devel seems to be the list (unfortunately subscriber only) where to send your patch to. Preferably use git-send-email and say in the message why the include is necessary.
Comment 4 Anthony Basile 2015-05-13 17:47:40 UTC
Has anyone sent this usptream?
Comment 5 Felix Janda 2015-05-16 21:01:47 UTC
Comment 6 Felix Janda 2015-08-10 19:27:03 UTC
Comment 7 Jory A. Pratt 2019-07-13 23:36:25 UTC
Current in tree version works with musl