Bug 543878

Summary:	eutils.eclass: epatch_user(): Extend error message for custom builds
Product:	Gentoo Linux	Reporter:	Sergey S. Starikoff <Ikonta>
Component:	Eclasses	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	arfrever.fta
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
Package list:		Runtime testing required:	---

Description Sergey S. Starikoff 2015-03-20 10:22:22 UTC

Yesterday I've got an issue (bug #543780 — my mistake):

>>> Failed to emerge x11-libs/gtk+-3.14.9, Log file:

>>>  '/var/tmp/portage/x11-libs/gtk+-3.14.9/temp/build.log'

 * Messages for package x11-libs/gtk+-3.14.9:

 * ERROR: x11-libs/gtk+-3.14.9::gentoo failed (compile phase):
 *   emake failed
 * 
 * If you need support, post the output of `emerge --info '=x11-libs/gtk+-3.14.9::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=x11-libs/gtk+-3.14.9::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/x11-libs/gtk+-3.14.9/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/x11-libs/gtk+-3.14.9/temp/environment'.
 * Working directory: '/var/tmp/portage/x11-libs/gtk+-3.14.9/work/gtk+-3.14.9-abi_x86_64.amd64'
 * S: '/var/tmp/portage/x11-libs/gtk+-3.14.9/work/gtk+-3.14.9'

Build failure was the result of incorrectly applyed (incompatible with current version of library) userpatch.

It would be fine, if in such cases portage will remind user to verify custom patch.
Adding to standard error message something like:

 * 
 * WARNING: failed build used custom patches:
 *   Please, first try to build $CATEGORY/$PACKAGE without them.

Comment 1 Arfrever Frehtes Taifersar Arahesis 2015-03-20 17:53:28 UTC

epatch_user() is provided by eutils.eclass, not sys-apps/portage.

I suggest that epatch_user() define a function (printing a message) and append its name to EBUILD_DEATH_HOOKS if epatch_user() applied any patches. (See java-utils-2.eclass.)

Comment 2 SpanKY gentoo-dev

2015-03-20 18:28:28 UTC

i've added it, but i'm not sure how useful it'll be in practice:
http://sources.gentoo.org/eclass/eutils.eclass?r1=1.443&r2=1.444