Summary: | sys-power/apcupsd-3.14.13: ebuild enhancement request | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | David Flogeras <dflogeras2> |
Component: | Current packages | Assignee: | John Einar Reitan <john.einar> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | base-system, james05+gentoo, joe9mail, jstein, k_f, orzel, paolo.pedroni |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
ebuild for 3.14.13
patch to add powerfail init script to upstream package /etc/init.d/apcupsd-powerfail script /etc/init.d/apcupsd script templlate ebuild for 3.14.13 |
Description
David Flogeras
2015-03-19 10:24:22 UTC
Would like to bump this request... Created attachment 416890 [details]
ebuild for 3.14.13
Created attachment 416892 [details, diff]
patch to add powerfail init script to upstream package
Created attachment 416894 [details]
/etc/init.d/apcupsd-powerfail script
Created attachment 416896 [details]
/etc/init.d/apcupsd script templlate
With this ebuild, I changed apcupsd.powerfail to apcupsd-powerfail, to avoid confusing this script with the script names of multiple apcupsd instances. Changes in this ebuild: 1. changed apcupsd.powerfail to apcupsd-powerfail, to avoid confusing this script with the script names of multiple apcupsd instances. 2. changed EAPI to 5 3. removed || die commands after eutils 4. used upstream mechanism to generate /etc/init.d/{apcupsd,apcupsd-powerfail} to avoid having to hardcode piddir, powerfaildir, sysconfdir, etc. 5. use the apcupsd.conf of the upstream package. That appears saner than the one packaged in the files/. 6. nisip defaulted to 127.0.0.1 instead of leaving it at 0.0.0.0 7. removed the configure argument for nis-port, as it defaults to 3551 anyway. 8. changed default --with-pwrfail-dir to /run/apcupsd from /etc/apcupsd, to help in situations where /etc is read-only. ebuild also here: https://github.com/joe9/portage/blob/master/sys-power/apcupsd/apcupsd-3.14.13.ebuild commit d2f026a3480457d00c8e6f8acfc4431892275dad Author: Lars Wendler <polynomial-c@gentoo.org> Date: Tue Dec 22 13:04:17 2015 sys-power/apcupsd: Bump to version 3.14.13 Package-Manager: portage-2.2.26 Signed-off-by: Lars Wendler <polynomial-c@gentoo.org> Unfortunately I missed your proposed changes. But to be honest incorporating them is more the topic of Matthew and thus I keep the bug open for him to maybe add a revbumped version of 3.14.13 (In reply to Joe M from comment #7) Would you please also change APCUPSD_MAIL from /bin/mail to /usr/bin/mail? The former no longer exists in current version of mail-client/mailx. Created attachment 471470 [details]
ebuild for 3.14.13
Updated the APCUPSD_MAIL from /bin/mail to /usr/bin/mail
(In reply to Matt Whitlock from comment #9) > (In reply to Joe M from comment #7) > > Would you please also change APCUPSD_MAIL from /bin/mail to /usr/bin/mail? > The former no longer exists in current version of mail-client/mailx. Updatedd the ebuild with the above change to /usr/bin/mail. Thanks |