Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 543306

Summary: net-analyzer/wireshark should depend on dev-libs/libgpg-error and x11-libs/cairo
Product: Gentoo Linux Reporter: Nikoli <nikoli>
Component: Current packagesAssignee: Gentoo Netmon project <netmon>
Status: RESOLVED INVALID    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Nikoli 2015-03-14 13:19:56 UTC
$ check-deps.sh net-analyzer/wireshark
 * Checking "net-analyzer/wireshark-1.12.4"
 * Missing in RDEPEND and DEPEND:
        dev-libs/libgpg-error
                X86_64;libgpg-error.so.0
                        /usr/lib64/libfiletap.so.0.0.4
                        /usr/lib64/libwireshark.so.5.0.4
                        /usr/lib64/libwiretap.so.4.0.4
                        /usr/lib64/libwsutil.so.4.1.0
        x11-libs/cairo
                X86_64;libcairo.so.2
                        /usr/bin/wireshark


cairo is for gtk UI only, dev-libs/libgpg-error is for USE crypt.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2015-03-15 12:13:00 UTC
net-analyzer/wireshark depends on dev-libs/libgcrypt which has a direct dependency on dev-libs/libgpg-error. If that changes, then `libgcrypt-config --libs' output ought to change as well, so I don't see why wireshark ebuilds should set this indirect dependency.

net-analyzer/wireshark depends on x11-libs/pango which has a direct dependency on x11-libs/cairo. If that changes, then `pkg-config --libs pango' ought to change as well, so I don't see why wireshark ebuilds should set this indirect dependency.

Maybe check-deps.sh needs a review - these are obviously false positives.
Comment 2 Nikoli 2015-03-15 13:03:37 UTC
No, the tool is working correctly: wireshark links directly to cairo libs and uses functions from /usr/include/cairo/cairo.h directly, example:
$ grep 'cairo_move_to(' ui/gtk/*.c|wc -l
92

/usr/include/cairo/cairo.h:cairo_move_to (cairo_t *cr, double x, double y);

But wireshark does not have '#include cairo.h'.


Same with dev-libs/libgpg-error: wireshark links directly to its libs and is using GPG_ERR_NO_ERROR error code, which is defined in /usr/include/x86_64-pc-linux-gnu/gpg-error.h

Also before reporting i did look at output of:
qgrep -N -A9 -B9 dev-libs/libgpg-error|grep 'dev-libs/libgcrypt'

It is common practise to have _both_ gcrypt and gpg-error in deps, even gnupg and cryptsetup packages do so.


> Maybe check-deps.sh needs a review - these are obviously false positives.

I asked for review several times - seems nobody is interested in autodetecting missing deps...