| Summary: | sys-process/criu: needs to support >=protobuf-c-1 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | SpanKY <vapier> |
| Component: | Current packages | Assignee: | Tim Harder <radhermit> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dlan, hwoarang, ivanhoe, pageexec |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | criu-1.5-r1 full log when build with dev-libs/protobuf-c-1.1.0 | ||
|
Description
SpanKY
2015-03-10 21:42:45 UTC
Ah right, that was the main blocker. I just assumed you would bump it to 1.5 for me... but it looks like that doesn't build against protobuf-c-1.1.0 anyway. sys-process/criu-1.4 builds fine with dev-libs/protobuf-c-1.0.2-r1. So maybe the ebuild should be changed this way: RDEPEND="<dev-libs/protobuf-c-1.1" And dev-libs/protobuf-c-1.1 should be masked. (In reply to Ivan Iraci from comment #2) that doesn't fix the problem: criu should work with the latest version, not something slightly newer than what it already does (In reply to SpanKY from comment #3) @vapier, regarding this, do you have any patch or plan to work on this? otherwise I'd agree with Ivan from #c2, that we should mask protobuf-c-1.1.0, and at least let criu-1.4 work with protobuf-c-1.0.2-r1 also, upstream has released criu-1.5, and I found it works with protobuf-c-1.0.2-r1, but fail to build with protobuf-c-1.1.0 (In reply to Yixun Lan from comment #4) i'm not working on it. Tim has taken a look, but i don't know how far he has gotten. masking a library because one package is broken is not how things work. if criu can't support the latest versions of software, then it should be masked and thrown away. (In reply to SpanKY from comment #5) Ok, I'd agree that masking protobuf-c-1.1.0 wasn't a good idea, since not just criu depend on it, but there are other packages. so how about 1) restrict dep like "<dev-libs/protobuf-c-1.1.0" only at criu side. and then 2) we can check code at upstream, or report to them, to work out a patch (better solution!) I think 1) is quick & simple solution, and doing 2) may takes a few more time. @radhermit, although you plan to drop maintainership of this package, could you still help us through it? I'm also CCing markos, see if he willing to take over this package, since criu is a dep of app-emulation/lxc (In reply to Yixun Lan from comment #6) oops, sorry for the noise.. great @radhermit already bumped to version 1.5 and fix the dep there! thanks (In reply to Yixun Lan from comment #6) bumping & allowing a newer version of protobuf-c is certainly fine and doesn't really make the status quo worse, but it doesn't close out this bug :) Created attachment 398772 [details]
criu-1.5-r1 full log when build with dev-libs/protobuf-c-1.1.0
Tim pointed that out to me -- it looks like files that use nested comments get mangled such that they are double nested and then you get a build failure probably should be easy to make criu work (strip out comments) but i'm not sure if that's expected behavior upstream fix for protobuf-c https://github.com/protobuf-c/protobuf-c/issues/185#event-254026579 I've tested and criu-1.5 works with protobuf-c-1.1.1 (we can remove the dep restriction: <dev-libs/protobuf-c-1.1.0) Closing since upstream fixed protobuf-c. |
