Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 542472

Summary: =net-proxy/squidguard-1.5_beta-r1 stabilization request
Product: Gentoo Linux Reporter: drserge
Component: [OLD] ServerAssignee: Sergey Popov (RETIRED) <pinkbyte>
Status: RESOLVED FIXED    
Severity: normal CC: eras
Priority: Normal Keywords: STABLEREQ
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=563368
Whiteboard: WAS: squidGuard does not support Squid 3.4+ new helper reply format
Package list:
Runtime testing required: ---
Attachments: Support Squid 3.4 reply format
Support Squid 3.4 reply format for 1.5_beta
Support Squid 3.4 reply format for 1.4
Support Squid 3.4 reply format for 1.5_beta

Description drserge 2015-03-07 20:57:51 UTC
Created attachment 398328 [details, diff]
Support Squid 3.4 reply format

Squid starting from version 3.4 expects different reply format from url_rewrite_program and interprets all returned by the standard squidGuard reply fields without space-separators as URL.
I.e. the reply "http://192.168.24.1/access.html 192.168.24.42/192.168.24.42 - GET" becomes "http://192.168.24.1/access.html192.168.24.42/192.168.24.42-GET".
The patch that adds support for new format with new command-line switch is in an attachment.
Comment 1 drserge 2015-03-07 21:38:41 UTC
Created attachment 398332 [details, diff]
Support Squid 3.4 reply format for 1.5_beta
Comment 2 drserge 2015-03-07 21:41:08 UTC
I've sent the patches to squidGuard developers too.
Comment 4 Brian Dolbec (RETIRED) gentoo-dev 2015-03-09 02:29:23 UTC
Eray, squidGuard is marked  maintainer-needed.  But since it is involving squid, I am hoping you can take care of any dep changes needed until upstream releases a new patched version.
Comment 5 drserge 2015-03-09 19:19:06 UTC
(In reply to drserge from comment #2)
> I've sent the patches to squidGuard developers too.

But the messages could not be delivered...
After examining the squidGuard mailing list archives the assumption that squidGuard is now unmaintained become much stronger.

The problem was discussed in Debian, FreeBSD and Squid bugtrackers/mailing lists...

I think we need to add patches to portage and add a warning about new command-line parameter to pkg_postinst einfo messages.
Comment 6 drserge 2015-03-09 19:19:48 UTC
Created attachment 398544 [details, diff]
Support Squid 3.4 reply format for 1.4
Comment 7 drserge 2015-03-09 19:20:26 UTC
Created attachment 398546 [details, diff]
Support Squid 3.4 reply format for 1.5_beta
Comment 8 drserge 2015-03-09 20:17:03 UTC
I've replaced patches with reworked ones.
Comment 9 Sergey Popov (RETIRED) gentoo-dev 2015-09-29 10:34:44 UTC
commit f4799d94d2e95a1c0303375b4bfe068481e5386a
Author: Sergey Popov <pinkbyte@gentoo.org>
Date:   Tue Sep 29 13:31:00 2015 +0300

    net-proxy/squidguard: revision bump

    Add patch to work correctly with Squid 3.4 and above
    Add support for user patches

    Package-Manager: portage-2.2.20


Fix applied in squidguard-1.5_beta-r1

I think we should stabilize it, cause 1.4 is quite old
Comment 10 Sergey Popov (RETIRED) gentoo-dev 2015-10-12 13:33:16 UTC
Arches, please test and mark stable =net-proxy/squidguard-1.5_beta-r1

Target keywords: amd64 ppc ppc64 sparc x86
Comment 11 Agostino Sarubbo gentoo-dev 2015-10-19 09:32:02 UTC
amd64 stable
Comment 12 Agostino Sarubbo gentoo-dev 2015-10-30 10:18:32 UTC
ppc stable
Comment 13 Agostino Sarubbo gentoo-dev 2015-11-03 16:20:40 UTC
x86 stable
Comment 14 Agostino Sarubbo gentoo-dev 2015-11-05 11:22:12 UTC
sparc stable
Comment 15 Agostino Sarubbo gentoo-dev 2015-11-13 09:43:31 UTC
ppc64 stable. Closing.